Closed Bug 779176 Opened 12 years ago Closed 12 years ago

Activities doesn't work with different entry points (not using href)

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17
blocking-basecamp +

People

(Reporter: arcturus, Assigned: fabrice)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20120723030606

Steps to reproduce:

We need the support for activities working from multiple entry points.

In the documentation we had the 

href: can be used to register an activity handler in another page. Needs to be same origin. 

that maybe we could use to define this.

Or support in the entry point declaration the activity.
Summary: Activities doesn't work with multiple entry points → Activities doesn't work with different entry points (not using href)
Blocks: 715814
blocking-basecamp: --- → ?
Component: General → DOM
Product: Boot2Gecko → Core
Version: unspecified → Trunk
Why is this a blocker? What V1 requirements are blocked on support for this?
Apparently it's required to integrate Contacts with the Dialer.
Status: UNCONFIRMED → NEW
Ever confirmed: true
blocking-basecamp: ? → +
Assignee: nobody → fabrice
Attached patch patchSplinter Review
Francisco, can you try a build with this patch, and adding the "href" property in the activity. It works there, but I'd like to be sure this is what you actually need.
Thanks Fabrice, will try today and will let you know.

Cheers!.
Hi Fabrice,

I tried the patch against the latest m-c, and this is the idea that we were proposing but currently is not working as expected.

I setup a email activity (I was working with them) in the following way:

"new": {
      "filters": {
        "type": "test"
      },
      "disposition": "window",
      "href": "ep/mail.html"
    }

My idea is trying to launch the file 'mail.html' inside the 'ep' folder (right now in apps i have: apps/mail/ep) to handle this activity.

I get a light-blue screen of death cause the system is trying to open the following page:

email.gaiamobile.com/index.html/ep/mail.html

So seems that we are always apending the launch_attribute from the original path and since we did a change that we added always the 'index.html' to the launch_path attribute, the 'href' seems to me that needs to be absolute path from the origin, not just the launch path.

Also tried the following trick, and everything worked as expected:

"new": {
      "filters": {
        "type": "test"
      },
      "disposition": "window",
      "href": "/../ep/mail.html"
    }

Cheers!
Francisco.
Forget anything about previous comment, somehow I was trying with an old copy of my b2g.

After realising that it was behaving as the old version, retried with the patched one and works like charm.

Following the example above:

"new": {
      "filters": {
        "type": "test"
      },
      "disposition": "window",
      "href": "ep/mail.html"
    }

It's opening correctly email.gaiamobile.org/ep/mail.html

Thanks a lot!

(In reply to francisco.jordano from comment #5)
> Hi Fabrice,
> 
> I tried the patch against the latest m-c, and this is the idea that we were
> proposing but currently is not working as expected.
> 
> I setup a email activity (I was working with them) in the following way:
> 
> "new": {
>       "filters": {
>         "type": "test"
>       },
>       "disposition": "window",
>       "href": "ep/mail.html"
>     }
> 
> My idea is trying to launch the file 'mail.html' inside the 'ep' folder
> (right now in apps i have: apps/mail/ep) to handle this activity.
> 
> I get a light-blue screen of death cause the system is trying to open the
> following page:
> 
> email.gaiamobile.com/index.html/ep/mail.html
> 
> So seems that we are always apending the launch_attribute from the original
> path and since we did a change that we added always the 'index.html' to the
> launch_path attribute, the 'href' seems to me that needs to be absolute path
> from the origin, not just the launch path.
> 
> Also tried the following trick, and everything worked as expected:
> 
> "new": {
>       "filters": {
>         "type": "test"
>       },
>       "disposition": "window",
>       "href": "/../ep/mail.html"
>     }
> 
> Cheers!
> Francisco.
Comment on attachment 649909 [details] [diff] [review]
patch

Not sure why we used fullLaunchPath here.. (and the startPoint support in this function looks broken also anyway, I'll file a bug).
Attachment #649909 - Flags: review?(mounir)
Attachment #649909 - Flags: review?(mounir) → review+
https://hg.mozilla.org/mozilla-central/rev/66b421cf32b9
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
QA Contact: jsmith
Whiteboard: [qa+]
Keywords: verifyme
Whiteboard: [qa+]
Keywords: verifyme
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: