779209 - Add support for 3GPP media files

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Inder]

Add support for 3gpp media files. Camcorder in certain configurations generates recorded files in 3gpp format.

Comment 1

[Inder]

Attachment: OmxPlugin patch to support 3gpp mime type.

Along with the attached patch following changes need to be made:

netwerk/mime/nsMimeTypes.h:
+#define VIDEO_3GPP                          "video/3gpp"

uriloader/exthandler/nsExternalHelperAppService.cpp:
-  { AUDIO_WAV, "wav", "Waveform Audio" }
+  { AUDIO_WAV, "wav", "Waveform Audio" },
+  { VIDEO_3GPP, "3gpp,3gp", "3GPP Video" }

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: 3gpp video file mime type definitions

Comment 3

[Andrew Overholt [:overholt]]

Do we have support for playing 3GPP files in the video player?

Comment 4

[Michael Vines [:m1] [:evilmachines]]

That is essentially what this patch is enabling.   Currently the video player chokes on a .3gpp extension

Comment 5

[Andrew Overholt [:overholt]]

While enabling this is trivial and I see no reason *not* to land this patch, I don't think this is something we'd block on.  Please remember, just because we're -ing here, it doesn't mean we wouldn't like to see this fixed :)

Comment 6

[Michael Vines [:m1] [:evilmachines]]

Sorry to nit as I'm sure we will land this patch in time for v1 regardless, but I want to ensure that the appropriate priority is placed on it.  If we don't land this patch for v1 then the videos that the user records will not be playable on their own device.

Comment 7

[Andreas Gal :gal]

Is there a chance to record in a web format instead of 3gpp?

Comment 8

[Michael Vines [:m1] [:evilmachines]]

We can do an mp4 container format as well, with a h263, h264 or m4v video codec

It's configurable via /system/etc/media_profiles.xml
eg: http://bit.ly/OSQ1q3

Comment 9

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Whups, this should not have been minused.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/05006509aa53

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0c1b52f5c8e0

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Crap, this got checked in to both branches as bug 722975. Stupid copy/paste error on my fault when I was giving this a commit message (one of the reasons I prefer they be there ahead of time :)...).
https://hg.mozilla.org/mozilla-central/rev/05006509aa53