Closed Bug 779254 Opened 10 years ago Closed 10 years ago

Stop appending --enable-update-packaging multiple times

Categories

(Release Engineering :: General, defect, P2)

Product:
Release Engineering
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: coop, Assigned: coop)

Details

(Whiteboard: [l10n][cleanup])

Attachments

(1 file)

Check for --enable-update-packaging in extraConfigureArgs before appending it again.
956 bytes, patch
armenzg
: review+
coop
: checked-in+
Details | Diff | Splinter Review 
When running configure for l10n repacks, we end up appending '--enable-update-packaging' multiple times. Here's a tame example, some are much, much worse:

'sh' '--' './configure' '--enable-application=browser' '--with-l10n-base=../l10n-central' '--with-macbundlename-prefix=Firefox' '--enable-update-packaging' '--enable-update-packaging' '--enable-update-packaging' '--enable-update-packaging'

We only need this once, and a simple check will suffice.
Attachment #647639 - Flags: review?(armenzg)
Attachment #647639 - Flags: review?(armenzg) → review+
Comment on attachment 647639 [details] [diff] [review]
Check for --enable-update-packaging in extraConfigureArgs before appending it again.

https://hg.mozilla.org/build/buildbotcustom/rev/2910a72cc4d4
Attachment #647639 - Flags: checked-in+
This made it into production yesterday afternoon.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.