Closed
Bug 779254
Opened 13 years ago
Closed 13 years ago
Stop appending --enable-update-packaging multiple times
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: coop, Assigned: coop)
Details
(Whiteboard: [l10n][cleanup])
Attachments
(1 file)
|
956 bytes,
patch
|
armenzg
:
review+
coop
:
checked-in+
|
Details | Diff | Splinter Review |
When running configure for l10n repacks, we end up appending '--enable-update-packaging' multiple times. Here's a tame example, some are much, much worse:
'sh' '--' './configure' '--enable-application=browser' '--with-l10n-base=../l10n-central' '--with-macbundlename-prefix=Firefox' '--enable-update-packaging' '--enable-update-packaging' '--enable-update-packaging' '--enable-update-packaging'
We only need this once, and a simple check will suffice.
Attachment #647639 -
Flags: review?(armenzg)
|
||
Updated•13 years ago
|
Attachment #647639 -
Flags: review?(armenzg) → review+
|
Assignee | |
Comment 1•13 years ago
|
||
Comment on attachment 647639 [details] [diff] [review]
Check for --enable-update-packaging in extraConfigureArgs before appending it again.
https://hg.mozilla.org/build/buildbotcustom/rev/2910a72cc4d4
Attachment #647639 -
Flags: checked-in+
|
||
Comment 2•13 years ago
|
||
This made it into production yesterday afternoon.
|
|
Assignee | |
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
|
|
||
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•