779273 - 500 Internal Server Error from hg.mozilla.org caused setting the screen resolution (mouse_and_screen_resolution.py) to fail, and tests to fail with a non-obvious error

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mark Banner (:standard8)]

We're using the new screen resolution setting code on the Thunderbird tree. We just had a 500 ISE whilst the builder was attempting to get the screen resolution file.

This branch does not seem to have the configuration file HTTP Error 500: Internal Server Error
Let's fail over to 1024x768.
Screen resolution (current): (1280, 1024)
Changing the screen resolution...
Screen resolution (new): (1024, 768)
Mouse position (current): (512, 384)
Mouse position (new): (1010, 10)
program finished with exit code 0
elapsedTime=6.501000

The actual tests then failed:

Test Failure: Timeout waiting for resize (is the screen resolution 1280 x 1024?)

but it isn't obvious that the set-up actually went wrong.

Can we make it so that the mouse_and_screen_resolution.py step aborts and retries on a 500 ISE (or just retries a number of times)?

Comment 1

[Mark Banner (:standard8)]

Here's the log file:

https://tbpl.mozilla.org/php/getParsedLog.php?id=14000071&full=1&branch=comm-central

Comment 2

[John Hopkins (:jhopkins)]

Attachment: proposed tools patch

tested wfetch function locally

Comment 3

[John Hopkins (:jhopkins)]

Attachment: proposed tools patch with retry functionality

tested standalone on a talos build machine with passing and failing urls; functions as expected.

Comment 4

[Armen [:armenzg]]

Comment on attachment 648050 [details] [diff] [review]
proposed tools patch with retry functionality

Review of attachment 648050 [details] [diff] [review]:
-----------------------------------------------------------------

You can push it to try if you want to or simply land it.

Comment 5

[John Hopkins (:jhopkins)]

Comment on attachment 648050 [details] [diff] [review]
proposed tools patch with retry functionality

Landed in https://hg.mozilla.org/build/tools/rev/31d98bfc1ae2