Closed
Bug 779361
Opened 12 years ago
Closed 12 years ago
IonMonkey: Reuse input in LAbsD and LSqrtD.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sstangl, Unassigned)
Details
(Whiteboard: [ion:t])
Attachments
(1 file)
3.86 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
LAbsD and LSqrtD can trivially reuse the input register.
Attachment #647770 -
Flags: review?(nicolas.b.pierron)
Updated•12 years ago
|
Whiteboard: [ion:t]
Updated•12 years ago
|
Attachment #647770 -
Flags: review?(nicolas.b.pierron) → review+
Reporter | ||
Comment 1•12 years ago
|
||
http://hg.mozilla.org/projects/ionmonkey/rev/f35b90ed0b8d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 2•12 years ago
|
||
This constrains regalloc a bit though, if you have var y = sqrt(x); var z = abs(x); // ..no other uses of x.. Regalloc could do x in r0 sqrt: r0 -> r1 abs : r0 -> r0 Now it has to use an explicit move: x in r0 move: r0 -> r1 sqrt: r1 -> r1 abs : r0 -> r0 I thought defineReuseInput was only used in cases where the hardware requires it (most non-FP instructions on x86).
Comment 3•12 years ago
|
||
So the useAtStart is good, but not the defineReuseInput ?
You need to log in
before you can comment on or make changes to this bug.
Description
•