Clean up some includes in a11y

RESOLVED FIXED in mozilla17

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

(Blocks: 1 bug)

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 647804 [details] [diff] [review]
Patch
Attachment #647804 - Flags: review?(surkov.alexander)

Comment 1

5 years ago
Comment on attachment 647804 [details] [diff] [review]
Patch

Review of attachment 647804 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

::: accessible/src/base/TextAttrs.h
@@ +196,5 @@
>    {
>    public:
>      LangTextAttr(HyperTextAccessible* aRoot, nsIContent* aRootElm,
>                   nsIContent* aElm);
> +    virtual ~LangTextAttr();

why is this change?
Attachment #647804 - Flags: review?(surkov.alexander) → review+

Updated

5 years ago
Blocks: 389800
(Assignee)

Comment 2

5 years ago
I moved the destructor out of line to avoid instantiating the nsCOMPtr<nsIContent> template, which allows us to forward declare nsIContent instead of including it.

Comment 3

5 years ago
I see, thanks
https://hg.mozilla.org/mozilla-central/rev/2df6ea8741e2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17

Updated

5 years ago
Assignee: nobody → dzbarsky
You need to log in before you can comment on or make changes to this bug.