Closed Bug 779386 Opened 7 years ago Closed 7 years ago

Clean up some includes in a11y

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: dzbarsky, Assigned: dzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
No description provided.
Attachment #647804 - Flags: review?(surkov.alexander)
Comment on attachment 647804 [details] [diff] [review]
Patch

Review of attachment 647804 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

::: accessible/src/base/TextAttrs.h
@@ +196,5 @@
>    {
>    public:
>      LangTextAttr(HyperTextAccessible* aRoot, nsIContent* aRootElm,
>                   nsIContent* aElm);
> +    virtual ~LangTextAttr();

why is this change?
Attachment #647804 - Flags: review?(surkov.alexander) → review+
I moved the destructor out of line to avoid instantiating the nsCOMPtr<nsIContent> template, which allows us to forward declare nsIContent instead of including it.
I see, thanks
https://hg.mozilla.org/mozilla-central/rev/2df6ea8741e2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Assignee: nobody → dzbarsky
You need to log in before you can comment on or make changes to this bug.