779386 - Clean up some includes in a11y

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 1

[alexander :surkov (:asurkov)]

Comment on attachment 647804 [details] [diff] [review]
Patch

Review of attachment 647804 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

::: accessible/src/base/TextAttrs.h
@@ +196,5 @@
>    {
>    public:
>      LangTextAttr(HyperTextAccessible* aRoot, nsIContent* aRootElm,
>                   nsIContent* aElm);
> +    virtual ~LangTextAttr();

why is this change?

Comment 2

[David Zbarsky (:dzbarsky)]

I moved the destructor out of line to avoid instantiating the nsCOMPtr<nsIContent> template, which allows us to forward declare nsIContent instead of including it.

Comment 3

[alexander :surkov (:asurkov)]

I see, thanks

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2df6ea8741e2