Last Comment Bug 779386 - Clean up some includes in a11y
: Clean up some includes in a11y
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: David Zbarsky (:dzbarsky)
:
Mentors:
Depends on:
Blocks: cleana11y
  Show dependency treegraph
 
Reported: 2012-07-31 18:29 PDT by David Zbarsky (:dzbarsky)
Modified: 2012-08-30 02:20 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (7.94 KB, patch)
2012-07-31 18:29 PDT, David Zbarsky (:dzbarsky)
surkov.alexander: review+
Details | Diff | Splinter Review

Description David Zbarsky (:dzbarsky) 2012-07-31 18:29:39 PDT
Created attachment 647804 [details] [diff] [review]
Patch
Comment 1 alexander :surkov 2012-07-31 20:34:49 PDT
Comment on attachment 647804 [details] [diff] [review]
Patch

Review of attachment 647804 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

::: accessible/src/base/TextAttrs.h
@@ +196,5 @@
>    {
>    public:
>      LangTextAttr(HyperTextAccessible* aRoot, nsIContent* aRootElm,
>                   nsIContent* aElm);
> +    virtual ~LangTextAttr();

why is this change?
Comment 2 David Zbarsky (:dzbarsky) 2012-07-31 22:44:22 PDT
I moved the destructor out of line to avoid instantiating the nsCOMPtr<nsIContent> template, which allows us to forward declare nsIContent instead of including it.
Comment 3 alexander :surkov 2012-08-01 04:14:08 PDT
I see, thanks
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-08-01 19:41:09 PDT
https://hg.mozilla.org/mozilla-central/rev/2df6ea8741e2

Note You need to log in before you can comment on or make changes to this bug.