779408 - error: cannot convert 'std::nullptr_t' to 'mozilla::gl::SharedTextureHandle {aka unsigned int} on gcc 4.6 in NDK r8b

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Makoto Kato [:m_kato]]

After nullptr implementation, gcc 4.6 in NDK r8b throws the following error.

dom/plugins/base/nsNPAPIPluginInstance.cpp:1025:17: error: cannot convert 'std::nullptr_t' to 'mozilla::gl::SharedTextureHandle {aka unsigned int}' in return

Comment 1

[Makoto Kato [:m_kato]]

/home/makoto/bin/android-ndk-r8b/toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86/bin/arm-linux-androideabi-g++ -o nsNPAPIPluginInstance.o -c  -fvisibility=hidden -D_IMPL_NS_LAYOUT -DXPCOM_TRANSLATE_NSGM_ENTRY_POINT=1 -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DSTATIC_EXPORTABLE_JS_API -DEXCLUDE_SKIA_DEPENDENCIES  -DOS_LINUX=1 -DOS_POSIX=1  -I/home/makoto/Development/hg.mozilla.org/mobile/dom/plugins/base/android -DSK_BUILD_FOR_ANDROID_NDK -I/home/makoto/Development/hg.mozilla.org/mobile/widget/android -I/home/makoto/Development/hg.mozilla.org/mobile/widget/xpwidgets -I/home/makoto/Development/hg.mozilla.org/mobile/xpcom/base/ -I/home/makoto/Development/hg.mozilla.org/mobile/gfx/skia/include/core -I/home/makoto/Development/hg.mozilla.org/mobile/gfx/skia/include/config -I/home/makoto/Development/hg.mozilla.org/objdir-android/dist/include/cairo   -I/home/makoto/Development/hg.mozilla.org/mobile/dom/base -I/home/makoto/Development/hg.mozilla.org/mobile/dom/battery -I/home/makoto/Development/hg.mozilla.org/mobile/dom/file -I/home/makoto/Development/hg.mozilla.org/mobile/dom/power -I/home/makoto/Development/hg.mozilla.org/mobile/dom/media -I/home/makoto/Development/hg.mozilla.org/mobile/dom/network/src -I/home/makoto/Development/hg.mozilla.org/mobile/dom/settings -I/home/makoto/Development/hg.mozilla.org/mobile/dom/sms/src -I/home/makoto/Development/hg.mozilla.org/mobile/dom/contacts -I/home/makoto/Development/hg.mozilla.org/mobile/dom/alarm -I/home/makoto/Development/hg.mozilla.org/mobile/dom/src/events -I/home/makoto/Development/hg.mozilla.org/mobile/dom/src/storage -I/home/makoto/Development/hg.mozilla.org/mobile/dom/src/offline -I/home/makoto/Development/hg.mozilla.org/mobile/dom/src/geolocation -I/home/makoto/Development/hg.mozilla.org/mobile/dom/src/notification -I/home/makoto/Development/hg.mozilla.org/mobile/dom/workers -I/home/makoto/Development/hg.mozilla.org/mobile/content/xbl/src -I/home/makoto/Development/hg.mozilla.org/mobile/content/xul/document/src -I/home/makoto/Development/hg.mozilla.org/mobile/content/events/src -I/home/makoto/Development/hg.mozilla.org/mobile/content/base/src -I/home/makoto/Development/hg.mozilla.org/mobile/content/html/content/src -I/home/makoto/Development/hg.mozilla.org/mobile/content/html/document/src -I/home/makoto/Development/hg.mozilla.org/mobile/content/svg/content/src -I/home/makoto/Development/hg.mozilla.org/mobile/layout/generic -I/home/makoto/Development/hg.mozilla.org/mobile/layout/style -I/home/makoto/Development/hg.mozilla.org/mobile/layout/xul/base/src -I/home/makoto/Development/hg.mozilla.org/mobile/layout/xul/base/src/tree/src -I/home/makoto/Development/hg.mozilla.org/mobile/dom/camera -I/home/makoto/Development/hg.mozilla.org/mobile/ipc/chromium/src -I/home/makoto/Development/hg.mozilla.org/mobile/ipc/glue -I../../../ipc/ipdl/_ipdlheaders  -I/home/makoto/Development/hg.mozilla.org/mobile/dom/plugins/base -I. -I../../../dist/include  -I/home/makoto/Development/hg.mozilla.org/objdir-android/dist/include/nspr -I/home/makoto/Development/hg.mozilla.org/objdir-android/dist/include/nss      -fPIC -isystem /home/makoto/bin/android-ndk-r8b/platforms/android-5/arch-arm/usr/include  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wno-ctor-dtor-privacy -Wno-overlength-strings -Wno-invalid-offsetof -Wno-variadic-macros -Wno-long-long -mandroid -fno-short-enums -fno-exceptions -Wno-psabi -march=armv7-a -mthumb -mfpu=vfp -mfloat-abi=softfp -I/home/makoto/Development/hg.mozilla.org/objdir-android/build/stlport -I/home/makoto/bin/android-ndk-r8b/sources/cxx-stl/stlport/stlport -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -std=gnu++0x -pipe -DNDEBUG -DTRIMMED -g -fno-omit-frame-pointer -funwind-tables -I/home/makoto/Development/hg.mozilla.org/objdir-android/dist/include/cairo   -isystem /home/makoto/bin/android-ndk-r8b/platforms/android-5/arch-arm/usr/include  -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MF .deps/nsNPAPIPluginInstance.o.pp /home/makoto/Development/hg.mozilla.org/mobile/dom/plugins/base/nsNPAPIPluginInstance.cpp
/home/makoto/Development/hg.mozilla.org/mobile/dom/plugins/base/nsNPAPIPluginInstance.cpp: In destructor 'SharedPluginTexture::~SharedPluginTexture()':
/home/makoto/Development/hg.mozilla.org/mobile/dom/plugins/base/nsNPAPIPluginInstance.cpp:99:22: error: cannot convert 'std::nullptr_t' to 'mozilla::gl::SharedTextureHandle {aka unsigned int}' in assignment
/home/makoto/Development/hg.mozilla.org/mobile/dom/plugins/base/nsNPAPIPluginInstance.cpp: In member function 'mozilla::gl::SharedTextureHandle SharedPluginTexture::CreateSharedHandle()':
/home/makoto/Development/hg.mozilla.org/mobile/dom/plugins/base/nsNPAPIPluginInstance.cpp:133:14: error: cannot convert 'std::nullptr_t' to 'mozilla::gl::SharedTextureHandle {aka unsigned int}' in return
/home/makoto/Development/hg.mozilla.org/mobile/dom/plugins/base/nsNPAPIPluginInstance.cpp:138:14: error: cannot convert 'std::nullptr_t' to 'mozilla::gl::SharedTextureHandle {aka unsigned int}' in return
/home/makoto/Development/hg.mozilla.org/mobile/dom/plugins/base/nsNPAPIPluginInstance.h: In constructor 'nsNPAPIPluginInstance::nsNPAPIPluginInstance()':
/home/makoto/Development/hg.mozilla.org/mobile/dom/plugins/base/nsNPAPIPluginInstance.h:350:8: warning: 'nsNPAPIPluginInstance::mOnScreen' will be initialized after [-Wreorder]
/home/makoto/Development/hg.mozilla.org/mobile/dom/plugins/base/nsNPAPIPluginInstance.h:291:12: warning:   'PRUint32 nsNPAPIPluginInstance::mFullScreenOrientation' [-Wreorder]
/home/makoto/Development/hg.mozilla.org/mobile/dom/plugins/base/nsNPAPIPluginInstance.cpp:168:1: warning:   when initialized here [-Wreorder]
/home/makoto/Development/hg.mozilla.org/mobile/dom/plugins/base/nsNPAPIPluginInstance.cpp: In member function 'mozilla::gl::SharedTextureHandle nsNPAPIPluginInstance::CreateSharedHandle()':
/home/makoto/Development/hg.mozilla.org/mobile/dom/plugins/base/nsNPAPIPluginInstance.cpp:1025:17: error: cannot convert 'std::nullptr_t' to 'mozilla::gl::SharedTextureHandle {aka unsigned int}' in return
make[2]: *** [nsNPAPIPluginInstance.o] Error 1
make[2]: Leaving directory `/home/makoto/Development/hg.mozilla.org/objdir-android/dom/plugins/base'
make[1]: *** [libs] Error 2
make[1]: Leaving directory `/home/makoto/Development/hg.mozilla.org/objdir-android/dom'

Comment 2

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Comment on attachment 647883 [details] [diff] [review]
fix

LGTM, but you should probably still get review from a peer.  roc might be a good choice.

Comment 4

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5d2c5daabf4

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c5d2c5daabf4