Closed
Bug 779442
Opened 13 years ago
Closed 13 years ago
Fix still more nsresult misuse
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(1 file)
|
4.50 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
The imgStatusTracker field here is used as a PRUint32 by all callers that I see. It's evidently meant to contain the values of an anonymous enum member of imgIRequest, so PRUint32 is the right type until someone gives it a name.
I'm not totally sure that the nsUrlClassifierStore change doesn't need module peer review -- it might be unintentional that it returns NS_OK.
Attachment #647892 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 647892 [details] [diff] [review]
Patch
(No part 2 intended here.)
Attachment #647892 -
Attachment description: Patch part 1 -- Fix a few more incorrect uses of nsresult → Patch
|
||
Updated•13 years ago
|
Attachment #647892 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Flags: in-testsuite-
Target Milestone: --- → mozilla17
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•