Fix still more nsresult misuse

RESOLVED FIXED in mozilla17

Status

()

Core
General
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

Trunk
mozilla17
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 647892 [details] [diff] [review]
Patch

The imgStatusTracker field here is used as a PRUint32 by all callers that I see.  It's evidently meant to contain the values of an anonymous enum member of imgIRequest, so PRUint32 is the right type until someone gives it a name.

I'm not totally sure that the nsUrlClassifierStore change doesn't need module peer review -- it might be unintentional that it returns NS_OK.
Attachment #647892 - Flags: review?(ehsan)
Comment on attachment 647892 [details] [diff] [review]
Patch

(No part 2 intended here.)
Attachment #647892 - Attachment description: Patch part 1 -- Fix a few more incorrect uses of nsresult → Patch
Attachment #647892 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e287b5a87971
Flags: in-testsuite-
Target Milestone: --- → mozilla17

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/e287b5a87971
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.