SegFault in WorkerMemoryReporter because it accesses mWorkerPrivate when null (only in debug builds)

RESOLVED FIXED in Firefox 16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(firefox16 fixed)

Details

Attachments

(1 attachment)

772 bytes, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 647893 [details] [diff] [review]
trivial patch

Working on bug 754671, my debug try builds crashed reliably in test_memoryReporters.xul. I could reproduce this locally and the culprit was pretty obvious. Attached a small patch that should fix this problem.
Attachment #647893 - Flags: review?(bent.mozilla)
Comment on attachment 647893 [details] [diff] [review]
trivial patch

Review of attachment 647893 [details] [diff] [review]:
-----------------------------------------------------------------

Oops :-/

Thanks!
Attachment #647893 - Flags: review?(bent.mozilla) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/c7a4be29936e
Whiteboard: [fixed-in-fx-team]
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/c7a4be29936e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla17
(Assignee)

Comment 4

5 years ago
Comment on attachment 647893 [details] [diff] [review]
trivial patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): ?
User impact if declined: we need this for bug 754671.
Testing completed (on m-c, etc.): Landed a long time ago on nightly.
Risk to taking this patch (and alternatives if risky): Virtually no risk.
String or UUID changes made by this patch: None.
Attachment #647893 - Flags: approval-mozilla-aurora?
Attachment #647893 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/d3d5c0b5aa75
status-firefox16: --- → fixed
You need to log in before you can comment on or make changes to this bug.