Closed
Bug 779516
Opened 13 years ago
Closed 13 years ago
BrowserAPI Methods are not defined if TOUCH_EVENTS_ENABLED_PREF is not defined
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: daleharvey, Assigned: daleharvey)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
1.93 KB,
patch
|
justin.lebar+bug
:
checkin+
|
Details | Diff | Splinter Review |
https://github.com/mozilla/mozilla-central/blob/master/dom/browser-element/BrowserElementParent.js#L192
This line will thrown an exception if the preference is not defined, which will cause the BrowserAPI methods to not be attached.
Patch will follow
|
||
Updated•13 years ago
|
Keywords: regression
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → dale
Attachment #647973 -
Flags: review?(justin.lebar+bug)
|
|
||
Comment 2•13 years ago
|
||
Comment on attachment 647973 [details] [diff] [review]
Bug 779516 - New getBoolPref function that takes default arguments. r=jlebar
We should really add this to the pref service, but that's for another day!
Attachment #647973 -
Flags: review?(justin.lebar+bug) → review+
|
|
||
Comment 3•13 years ago
|
||
Sorry to nit, but can you please change the commit message to explain what you're fixing (rather than how you're fixing it)?
|
|
Assignee | |
Comment 4•13 years ago
|
||
Attachment #647973 -
Attachment is obsolete: true
Attachment #647992 -
Flags: checkin?(justin.lebar+bug)
|
|
||
Comment 5•13 years ago
|
||
|
|
||
Updated•13 years ago
|
Attachment #647992 -
Flags: checkin?(justin.lebar+bug) → checkin+
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•