BrowserAPI Methods are not defined if TOUCH_EVENTS_ENABLED_PREF is not defined

RESOLVED FIXED in mozilla17

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: daleharvey, Assigned: daleharvey)

Tracking

({regression})

unspecified
mozilla17
x86
Mac OS X
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
https://github.com/mozilla/mozilla-central/blob/master/dom/browser-element/BrowserElementParent.js#L192 

This line will thrown an exception if the preference is not defined, which will cause the BrowserAPI methods to not be attached.

Patch will follow
Blocks: 774809
Keywords: regression
(Assignee)

Comment 1

5 years ago
Created attachment 647973 [details] [diff] [review]
Bug 779516 - New getBoolPref function that takes default arguments. r=jlebar
Assignee: nobody → dale
Attachment #647973 - Flags: review?(justin.lebar+bug)
Comment on attachment 647973 [details] [diff] [review]
Bug 779516 - New getBoolPref function that takes default arguments. r=jlebar

We should really add this to the pref service, but that's for another day!
Attachment #647973 - Flags: review?(justin.lebar+bug) → review+
Sorry to nit, but can you please change the commit message to explain what you're fixing (rather than how you're fixing it)?
(Assignee)

Comment 4

5 years ago
Created attachment 647992 [details] [diff] [review]
Bug 779516 - BrowserAPI Methods arent defined if TOUCH_EVENTS_ENABLED_PREF is not defined. r=jlebar
Attachment #647973 - Attachment is obsolete: true
Attachment #647992 - Flags: checkin?(justin.lebar+bug)
https://hg.mozilla.org/integration/mozilla-inbound/rev/78d893dda88f
Attachment #647992 - Flags: checkin?(justin.lebar+bug) → checkin+
https://hg.mozilla.org/mozilla-central/rev/78d893dda88f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.