Last Comment Bug 779516 - BrowserAPI Methods are not defined if TOUCH_EVENTS_ENABLED_PREF is not defined
: BrowserAPI Methods are not defined if TOUCH_EVENTS_ENABLED_PREF is not defined
Status: RESOLVED FIXED
: regression
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla17
Assigned To: Dale Harvey (:daleharvey)
:
Mentors:
Depends on:
Blocks: 774809
  Show dependency treegraph
 
Reported: 2012-08-01 08:34 PDT by Dale Harvey (:daleharvey)
Modified: 2012-08-01 19:41 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Bug 779516 - New getBoolPref function that takes default arguments. r=jlebar (1.91 KB, patch)
2012-08-01 09:10 PDT, Dale Harvey (:daleharvey)
justin.lebar+bug: review+
Details | Diff | Review
Bug 779516 - BrowserAPI Methods arent defined if TOUCH_EVENTS_ENABLED_PREF is not defined. r=jlebar (1.93 KB, patch)
2012-08-01 09:36 PDT, Dale Harvey (:daleharvey)
justin.lebar+bug: checkin+
Details | Diff | Review

Description Dale Harvey (:daleharvey) 2012-08-01 08:34:12 PDT
https://github.com/mozilla/mozilla-central/blob/master/dom/browser-element/BrowserElementParent.js#L192 

This line will thrown an exception if the preference is not defined, which will cause the BrowserAPI methods to not be attached.

Patch will follow
Comment 1 Dale Harvey (:daleharvey) 2012-08-01 09:10:57 PDT
Created attachment 647973 [details] [diff] [review]
Bug 779516 - New getBoolPref function that takes default arguments. r=jlebar
Comment 2 Justin Lebar (not reading bugmail) 2012-08-01 09:13:40 PDT
Comment on attachment 647973 [details] [diff] [review]
Bug 779516 - New getBoolPref function that takes default arguments. r=jlebar

We should really add this to the pref service, but that's for another day!
Comment 3 Justin Lebar (not reading bugmail) 2012-08-01 09:30:14 PDT
Sorry to nit, but can you please change the commit message to explain what you're fixing (rather than how you're fixing it)?
Comment 4 Dale Harvey (:daleharvey) 2012-08-01 09:36:00 PDT
Created attachment 647992 [details] [diff] [review]
Bug 779516 - BrowserAPI Methods arent defined if TOUCH_EVENTS_ENABLED_PREF is not defined. r=jlebar
Comment 5 Justin Lebar (not reading bugmail) 2012-08-01 11:41:51 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/78d893dda88f
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-08-01 19:41:04 PDT
https://hg.mozilla.org/mozilla-central/rev/78d893dda88f

Note You need to log in before you can comment on or make changes to this bug.