Closed Bug 779560 Opened 8 years ago Closed 8 years ago

dom/workers/test/test_recursion.html fails on ASan builds

Categories

(Core :: DOM: Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: decoder, Assigned: decoder)

Details

(Keywords: sec-want, Whiteboard: [asan-test-failure])

Attachments

(1 file, 1 obsolete file)

The mochitest dom/workers/test/test_recursion.html is crashing due to stack space exhaustion (ASan has higher stack space consumption), so I'd like to disable this test, as it's turning mochitest-4 orange on tbpl.
Attached patch Patch (obsolete) — Splinter Review
Patch, r=Ms2ger on IRC.
Assignee: nobody → choller
Status: NEW → ASSIGNED
Attachment #648006 - Flags: review+
Comment on attachment 648006 [details] [diff] [review]
Patch

Hopefully through IRC chat we've found a different plan of attack here. In general failing tests should not be disabled without a bit of investigation.
Attachment #648006 - Flags: review+ → review-
Yep, I'm compiling with some modifications right now to see whats the best solution here. Overall, we wouldn't care about the test failure right now if it was not easy to solve, since we have other stuff with higher priority on these builds. But I think what we discussed on IRC will work :) Will update this bug once testing is complete.
Summary: Disable dom/workers/test/test_recursion.html on ASan builds → dom/workers/test/test_recursion.html fails on ASan builds
Attached patch Updated patchSplinter Review
This patch reverts the ASan specific stack limit for workers in RuntimeService.cpp. With this change, all dom/workers/ tests are green on ASan, but compared to normal builds, ASan builds will be able to perform less recursive calls with workers. That is no immediate problem right now for ASan builds though.
Attachment #648006 - Attachment is obsolete: true
Attachment #648040 - Flags: review?(bent.mozilla)
Attachment #648040 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/1a3111e8b478
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.