Last Comment Bug 779573 - Empty string as default dictionary member in WebIDL causes compilation to fail.
: Empty string as default dictionary member in WebIDL causes compilation to fail.
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla17
Assigned To: William Chen [:wchen]
:
Mentors:
Depends on:
Blocks: 771636
  Show dependency treegraph
 
Reported: 2012-08-01 11:31 PDT by William Chen [:wchen]
Modified: 2012-08-02 06:21 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix generated code for empty string as default dictionary member in WebIDL. (1.41 KB, patch)
2012-08-01 11:35 PDT, William Chen [:wchen]
khuey: review+
Details | Diff | Splinter Review

Description William Chen [:wchen] 2012-08-01 11:31:18 PDT
dictionary NotificationOptions {
  DOMString lang = "";
};

Generates in the bindings:

static const PRUnichar data[] = { , 0 };

This causes compilation to fail.
Comment 1 William Chen [:wchen] 2012-08-01 11:35:32 PDT
Created attachment 648024 [details] [diff] [review]
Fix generated code for empty string as default dictionary member in WebIDL.
Comment 2 Ryan VanderMeulen [:RyanVM] 2012-08-01 19:25:18 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/71531b2ece95
Comment 3 Ed Morley [:emorley] 2012-08-02 06:21:49 PDT
https://hg.mozilla.org/mozilla-central/rev/71531b2ece95

Note You need to log in before you can comment on or make changes to this bug.