779599 - Consider doing animations of transforms on frames that are svg transformed off the main thread

Status: REOPENED

(Core :: DOM: Animation, task)

Comment 1

[David Zbarsky (:dzbarsky)]

Opacity already works.   Transform can't be animated until SVG attributes are promoted to properties.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I think this could work now? Do you know what's the issue if we just remove this?

Comment 3

[Robert Longson [:longsonr]]

What David said in comment 11 is still true i.e. we haven't unified transform attributes and transform properties. Having said that it might well work now anyway. I guess we'd have to try it and see.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Ah, I missed that transform wasn't mapped (I guess I confused it with transform-origin here).

So I guess we'd need to audit the transform syntax and make sure to use the CSS parser instead of this, or keep using the custom parser etc.

Comment 5

[Robert Longson [:longsonr]]

It needs custom parsing because transform attributes don't have units but CSS transform properties do.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Well sure but we already allow unitless lengths for all svg mapped attributes. But yeah cam mentioned the lack of commas in bug 878346 which might be more problematic.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:bhood, could you have a look please?

For more information, please visit BugBot documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

works now.

Comment 9

[Robert Longson [:longsonr]]

This needs more work. I have a mochitest that fails without the patch I'm just going to attach.

Comment 10

[Robert Longson [:longsonr]]

Attachment: Bug 779599 - Do SVG transforms on compositor r=emilio

Comment 11

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=00351789e3bf77c7a2405c5ccea4407afb621b86

Comment 12

[Robert Longson [:longsonr]]

Most SVG transforms happen on the compositor now. Those that don't are where we have a viewBox on the parent e.g. a symbol with a viewBox or an inner svg element with a viewBox.

We'd need to teach compositor how to handle these transforms to complete this bug.