7796 - [PP]nsDeviceContextMac::GetDeviceSurfaceDimensions is not impliment on the mac

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[davidm]

The following diff makes the mac work in a limited fashion
	Index: nsDeviceContextMac.cpp
===================================================================
RCS file: /cvsroot/mozilla/gfx/src/mac/nsDeviceContextMac.cpp,v
retrieving revision 1.51
diff -r1.51 nsDeviceContextMac.cpp
324,325c324
<   aWidth = 1;
<   aHeight = 1;
---
> 	GDHandle device = ::GetMainDevice();;
326a326,327
> 	aWidth = (**device).gdRect.right;
> 	aHeight = (**device).gdRect.bottom;

but someone really should do the work to be multimonitor friendly. As there is no
gfx component I am assiging to layout

Comment 1

[davidm]

Note that the above code is wrong since from some reason the PRInt32 is really
supposed to be one of the fixed point values. I don't know why.

Comment 2

[Peter Trudelle]

assigning to beard per rickg

Comment 3

[Peter Trudelle]

targetting m8 per rickg

Comment 4

[Chris Petersen]

This issue is occuring in the June 30th (1999063009)

Comment 5

[chris hofmann]

moving to m9. beard's on vacation

Comment 6

[Patrick C. Beard]

I put in a quick fix that just uses the GrayRgn (the region encompassing the
entire desktop) and returns the dimensions of its bounding box. Checked fix in as
mozilla/gfx/src/mac/nsDeviceContextMac.cpp,1.52.

Comment 7

[Chris Petersen]

Based on Bread's comments, marking as verified fixed.