779641 - error occurred while processing 'attach' request: TypeError: this._tabActor._tabbrowser is undefined

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Michael Schwartz [:m4]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/536.11 (KHTML, like Gecko) Chrome/20.0.1132.57 Safari/536.11

Steps to reproduce:

# Build b2g on tip from 7/31/12
# Setup for debugging as per this thread https://groups.google.com/forum/#!msg/mozilla.dev.b2g/UpDp2uTD4Mc/lM_Moiu2QRoJ
# Start b2g and verify debugging port listening
# Start up-to-date Firefox Nightly (8/1/12), enable remote debugging, enable debug logging, connect


Actual results:

Following error is printed from Firefox Nightly:

DBG-CLIENT: Got: {
  "from": "root",
  "applicationType": "browser",
  "traits": []
}
DBG-CLIENT: Got: {
  "from": "root",
  "selected": 0,
  "tabs": [
    { 
      "actor": "conn0.tab2",
      "url": "chrome://browser/content/shell.xul"
    }
  ]
}
DBG-CLIENT: Got: {
  "error": "unknownError",
  "message": "error occurred while processing 'attach' request: TypeError: this._tabActor._tabbrowser is undefined",
  "from": "conn0.tab2"
}



Expected results:

It should have connected with debugging

Comment 1

[Michael Schwartz [:m4]]

Note, b2g refers to B2g desktop as per https://developer.mozilla.org/en/Mozilla/Boot_to_Gecko/Using_the_B2G_desktop_client
Everything run on Ubuntu 12.04 LTS x86

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Ugh, this is a regression from bug 751226, because it didn't take into account the changes in bug 751949 that I worked on at about the same time. I might had tested it before landing if I wasn't away on vacation, but we desperately need to run our tests against b2g. I'll have a patch ready, shortly.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v1

This was the simplest solution that worked and I think the best. Bug 751949 doesn't concern b2g or fennec, so it makes sense to keep them oblivious to the web progress listener's presence.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=868b15707fa7

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/2fdb5c89e9e2

Comment 6

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/2fdb5c89e9e2