FT2_ flags overriden by MOZ_TREE_FREETYPE env setup and fontconfig get's dropped

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 648137 [details] [diff] [review]
Append tree freetype flags libs to existing FT2_flags/libs

I'm trying to build simple linuxgl gecko build with FTConfig and getting FT2_FLAGS/LIBS overriden by 
http://mxr.mozilla.org/mozilla-central/source/configure.in#6047
Attachment #648137 - Flags: review?(mh+mozilla)
Attachment #648137 - Flags: review?(jfkthame)
Comment on attachment 648137 [details] [diff] [review]
Append tree freetype flags libs to existing FT2_flags/libs

Review of attachment 648137 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +6111,2 @@
>     CAIRO_FT_CFLAGS='-I$(topsrcdir)/modules/freetype2/include'
> +   FT2_LIBS="'$(call EXPAND_LIBNAME_PATH,freetype,$(DEPTH)/modules/freetype2/.libs)' $FT2_LIBS"

That's not a good idea, because FT2_CFLAGS/LIBS contain flags for system freetype *and* fontconfig. What you really want is to add fontconfig flags alone.
Attachment #648137 - Flags: review?(mh+mozilla) → review-
(Assignee)

Comment 2

5 years ago
Created attachment 648898 [details] [diff] [review]
Standalone fontconfig flags

https://tbpl.mozilla.org/?tree=Try&rev=6517663604e5 - try build looks ok
Assignee: nobody → romaxa
Attachment #648137 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #648137 - Flags: review?(jfkthame)
Attachment #648898 - Flags: review?(mh+mozilla)
Comment on attachment 648898 [details] [diff] [review]
Standalone fontconfig flags

Review of attachment 648898 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +6047,5 @@
> +            FT2_CFLAGS="$FT2_CFLAGS $FONTCONFIG_CFLAGS"
> +            FT2_LIBS="$FT2_LIBS $FONTCONFIG_LIBS"
> +        fi
> +    ])
> +fi

There's another USE_FC_FREETYPE further down that's going to overwrite the FT2_* flags :(
Attachment #648898 - Flags: review?(mh+mozilla) → review-
(Assignee)

Comment 4

5 years ago
Created attachment 649026 [details] [diff] [review]
Standalone fontconfig flags

yep, I had that in mind but forgot to update a last moment. :(
Attachment #648898 - Attachment is obsolete: true
Attachment #649026 - Flags: review?(mh+mozilla)
Comment on attachment 649026 [details] [diff] [review]
Standalone fontconfig flags

Review of attachment 649026 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, assuming it passes linux try.
Attachment #649026 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 6

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=a56a249624c8
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/6c60e99d9739
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.