Closed
Bug 779679
Opened 13 years ago
Closed 13 years ago
FT2_ flags overriden by MOZ_TREE_FREETYPE env setup and fontconfig get's dropped
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: romaxa, Assigned: romaxa)
Details
Attachments
(1 file, 2 obsolete files)
|
3.61 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
I'm trying to build simple linuxgl gecko build with FTConfig and getting FT2_FLAGS/LIBS overriden by
http://mxr.mozilla.org/mozilla-central/source/configure.in#6047
Attachment #648137 -
Flags: review?(mh+mozilla)
Attachment #648137 -
Flags: review?(jfkthame)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 648137 [details] [diff] [review]
Append tree freetype flags libs to existing FT2_flags/libs
Review of attachment 648137 [details] [diff] [review]:
-----------------------------------------------------------------
::: configure.in
@@ +6111,2 @@
> CAIRO_FT_CFLAGS='-I$(topsrcdir)/modules/freetype2/include'
> + FT2_LIBS="'$(call EXPAND_LIBNAME_PATH,freetype,$(DEPTH)/modules/freetype2/.libs)' $FT2_LIBS"
That's not a good idea, because FT2_CFLAGS/LIBS contain flags for system freetype *and* fontconfig. What you really want is to add fontconfig flags alone.
Attachment #648137 -
Flags: review?(mh+mozilla) → review-
|
Assignee | |
Comment 2•13 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=6517663604e5 - try build looks ok
Assignee: nobody → romaxa
Attachment #648137 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #648137 -
Flags: review?(jfkthame)
Attachment #648898 -
Flags: review?(mh+mozilla)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 648898 [details] [diff] [review]
Standalone fontconfig flags
Review of attachment 648898 [details] [diff] [review]:
-----------------------------------------------------------------
::: configure.in
@@ +6047,5 @@
> + FT2_CFLAGS="$FT2_CFLAGS $FONTCONFIG_CFLAGS"
> + FT2_LIBS="$FT2_LIBS $FONTCONFIG_LIBS"
> + fi
> + ])
> +fi
There's another USE_FC_FREETYPE further down that's going to overwrite the FT2_* flags :(
Attachment #648898 -
Flags: review?(mh+mozilla) → review-
|
|
Assignee | |
Comment 4•13 years ago
|
||
yep, I had that in mind but forgot to update a last moment. :(
Attachment #648898 -
Attachment is obsolete: true
Attachment #649026 -
Flags: review?(mh+mozilla)
|
|
||
Comment 5•13 years ago
|
||
Comment on attachment 649026 [details] [diff] [review]
Standalone fontconfig flags
Review of attachment 649026 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good, assuming it passes linux try.
Attachment #649026 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
|
|
Assignee | |
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•