"Assertion failure: ret == 1" in js::Compressor::compressMore

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
--
critical
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Jesse Ruderman, Assigned: Benjamin)

Tracking

(Blocks: 1 bug, {assertion, regression, testcase})

Trunk
mozilla17
x86_64
Mac OS X
assertion, regression, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 648162 [details]
testcase (asserts fatally when loaded)

Assertion failure: ret == 1, at js/src/jsutil.cpp:75
(Reporter)

Comment 1

5 years ago
Created attachment 648163 [details]
stack trace
(Assignee)

Comment 2

5 years ago
Created attachment 648171 [details] [diff] [review]
handle zlib errors correctly
Assignee: general → bpeterson
Attachment #648171 - Flags: review?(jorendorff)
Comment on attachment 648171 [details] [diff] [review]
handle zlib errors correctly

Wow. Hard to believe we didn't have a test for this.
Attachment #648171 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 4

5 years ago
(In reply to Jason Orendorff [:jorendorff] from comment #3)
> Comment on attachment 648171 [details] [diff] [review]
> handle zlib errors correctly
> 
> Wow. Hard to believe we didn't have a test for this.

If it makes you feel better, it was handled correctly most of the time. :)
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f23ed15a005
https://hg.mozilla.org/mozilla-central/rev/8f23ed15a005
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
A testcase for this bug was automatically identified at js/src/jit-test/tests/basic/function-tosource-bug779694.js.
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.