779701 - Marionette tests aren't packaged properly on Windows

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch v1

https://tbpl.mozilla.org/php/getParsedLog.php?id=14043656&tree=Firefox&full=1

e:/builds/moz2_slave/m-cen-w32/build/obj-firefox/_virtualenv/Scripts/python.exe /e/builds/moz2_slave/m-cen-w32/build/testing/marionette/client/marionette/tests/print-manifest-dirs.py \
          /e/builds/moz2_slave/m-cen-w32/build \
          /e/builds/moz2_slave/m-cen-w32/build/testing/marionette/client/marionette/tests/unit-tests.ini \
          | (cd /e/builds/moz2_slave/m-cen-w32/build && xargs tar -chf -) \
          | (cd ./dist/test-package-stage/marionette/tests && tar -xf -)
tar: testingmarionetteclientmarionettetests: Cannot stat: No such file or directory
tar: domsmstestsmarionette: Cannot stat: No such file or directory
tar: domnetworktestsmarionette: Cannot stat: No such file or directory
tar: dombatterytestmarionette: Cannot stat: No such file or directory
tar: domtelephonytestmarionette: Cannot stat: No such file or directory
tar: testingmarionetteclientmarionettetestsunit: Cannot stat: No such file or directory
tar: Error exit delayed from previous errors

The error isn't detected because it's in the middle of a pipe. We really should do something about that. :/

Comment 1

[Rain [:rain1] (inactive)]

(The problem is that backslashes are unescaped by the shell)

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 648167 [details] [diff] [review]
patch v1

Review of attachment 648167 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fix!

Comment 3

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ba3fa936e3f6

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ba3fa936e3f6