cleanup linker cruft for FreeBSD from configure

RESOLVED FIXED in mozilla17

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jan Beich, Assigned: Jan Beich)

Tracking

(Blocks: 1 bug)

Trunk
mozilla17
All
FreeBSD
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
- a.out is no longer supported by FreeBSD ld(1) since r103436.
- -lc_r is no longer the default threading library since r125230.
- not GNU compatible linkers are unlikely to be supported*

This doesn't affect ldflags for libraries, they're still

  DSO_LDOPTS='-shared -Wl,-z,defs'

for both clang and gcc, same as on Linux.

http://svn.freebsd.org/changeset/base/103436
http://svn.freebsd.org/changeset/base/125230
* http://lists.freebsd.org/pipermail/freebsd-toolchain/2012-July/000438.html
(Assignee)

Comment 1

5 years ago
Created attachment 648172 [details] [diff] [review]
remove obsolete stuff
Attachment #648172 - Flags: review?(khuey)
Comment on attachment 648172 [details] [diff] [review]
remove obsolete stuff

I think that will make DLL_SUFFIX default ".so", not sure that's what you want. DSO_LDOPTS is set to '-shared' anyway in the 'GNU specific defaults' section.

Updated

5 years ago
Assignee: nobody → jbeich
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 3

5 years ago
(In reply to Landry Breuil (:gaston) from comment #2)
> I think that will make DLL_SUFFIX default ".so", not sure that's what you want.

It was this way for a long time and worked fine. At least ld(1) wants ".so" suffix for ELF libs (to make -lfoo work). FreeBSD rtld(1) works fine even with empty suffix and only wants ".so.1" if the intent is to share common libs via ldconfig hints. The latter may not work compared to per-library sharing via --(with|enable)-system-foo, e.g. trying using libxul from firefox13 on firefox14.

Here's a part that removes ".so.MAJOR.MINOR" support for base system
http://svnweb.freebsd.org/base/head/share/mk/bsd.lib.mk?r1=103436&r2=103435&pathrev=103436
SHLIB_NAME=	lib${LIB}.so.${SHLIB_MAJOR} # ELF
SHLIB_NAME?=	lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR} # AOUT
Comment on attachment 648172 [details] [diff] [review]
remove obsolete stuff

Review of attachment 648172 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not really knowledgeable about FreeBSD , but I'm happy to go along with this.
Attachment #648172 - Flags: review?(khuey) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 649308 [details] [diff] [review]
checkin version
Attachment #648172 - Attachment is obsolete: true
Attachment #649308 - Flags: checkin?
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d5f326881c7
Keywords: checkin-needed
Target Milestone: --- → mozilla17
Attachment #649308 - Flags: checkin? → checkin+

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/9d5f326881c7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Blocks: 784058
(Assignee)

Updated

5 years ago
Depends on: 436806
You need to log in before you can comment on or make changes to this bug.