779732 - Make search operations in the debugger more intuitive

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Victor Porof [:vporof][:vp]]

We're currently relying on operators for searching scripts, tokens etc. These are hard to discover (even if documented somewhere). It would be a good idea to have some UI for this, like a dropdown menu for search or something more fancy.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: screenshot

Pretty panels!

Comment 4

[Victor Porof [:vporof][:vp]]

Should probably append some key shortcuts info on those strings.
Can totally follow up for this.

Comment 5

[Victor Porof [:vporof][:vp]]

(In reply to Victor Porof [:vp] from comment #4)
> Should probably append some key shortcuts info on those strings.
> Can totally follow up for this.

Filed bug 785889.

Comment 6

[Victor Porof [:vporof][:vp]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=a5140deb9ca1

Comment 7

[Victor Porof [:vporof][:vp]]

Attachment: v1.1

Making sure this is the latest patch.

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 655906 [details] [diff] [review]
v1.1

+  _onScriptsSearchClick: function DVS__onScriptsSearchClick() {
+    // If the webpage has no scripts, searching is redundant.
+    if (!this._scripts.itemCount) {
+      return;
+    }

might this be confusing? If a user clicks there expecting to see the helpful popup, they won't know why it isn't there.

looks good!

Comment 9

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #8)
> Comment on attachment 655906 [details] [diff] [review]
> v1.1
> 
> +  _onScriptsSearchClick: function DVS__onScriptsSearchClick() {
> +    // If the webpage has no scripts, searching is redundant.
> +    if (!this._scripts.itemCount) {
> +      return;
> +    }
> 
> might this be confusing? If a user clicks there expecting to see the helpful
> popup, they won't know why it isn't there.
> 
> looks good!

But then again, seeing it may suggest that they have something to search for?
Anyway, pretty remote case imo. You don't see people debugging pages without scripts very often.

Comment 10

[Rob Campbell [:rc] (:robcee)]

yeah. Maybe best to just ditch that check altogether. Fewer lines ftw!

Comment 11

[Victor Porof [:vporof][:vp]]

Attachment: v1.2 [land-me]

Comment 12

[Victor Porof [:vporof][:vp]]

Attachment: v1.3

Rebased

Comment 13

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/80ed8842778d

Comment 14

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/80ed8842778d