Closed Bug 779739 Opened 12 years ago Closed 11 years ago

No limitation on additional entries created for manually added search engines

Categories

(Firefox for Android Graveyard :: Add-on Manager, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox15 affected, firefox16 affected, firefox17 affected, firefox18 affected, firefox20 affected, firefox22 affected, firefox23 affected, firefox24 affected, firefox25 affected, firefox26 affected, fennec+)

RESOLVED WONTFIX
Tracking Status
firefox15 --- affected
firefox16 --- affected
firefox17 --- affected
firefox18 --- affected
firefox20 --- affected
firefox22 --- affected
firefox23 --- affected
firefox24 --- affected
firefox25 --- affected
firefox26 --- affected
fennec + ---

People

(Reporter: paul.feher, Unassigned)

References

Details

Firefox Mobile Native 15.0b3 build1 (2012-07-31)
Device: HTC Desire Z(Android 2.3.3)

Steps to reproduce:
1. Visit www.google.com
2. Long-tap in the search field to bring up the Context Menu. Choose "Add
Search Engine".
3. Repeat steps 1 and 2.

Expected results:
After step 3 an error message appears that tells you that the search engine is already installed.

Actual results:
After step 3 there is no error message and the search engine is added again.
Blocks: 725213
tracking-fennec: --- → ?
tracking-fennec: ? → +
Assignee: nobody → bnicholson
Version: Firefox 15 → Trunk
Assignee: bnicholson → nobody
This is also reproducing after latest changes(Bug 892094).
Brian, do you want to make this into a mentor bug?
Flags: needinfo?(bnicholson)
Note that users may want to add multiple search engines for the same site. For example, I may want to add multiple Bugzilla engines that each correspond to a different Bugzilla query. The current behavior is that if a search engine (e.g., DuckDuckGo) already exists as an added engine, it's added again with an incremented number (e.g., "DuckDuckGo 2"). This is done by design: http://hg.mozilla.org/mozilla-central/file/e3785e299ab6/mobile/android/chrome/content/browser.js#l6649

So if we want to avoid duplicates, we shouldn't just go by URL or name, making this bug trickier than it seems. Search engines are created based on the form that uses the input field, so we could maybe go through every field and detect a duplicate if all field values match. But sites often put generated data in hidden form field; as a result, the form data ends up changing frequently, so basic field checking may not work well.

Is this really an issue? I'm tempted to mark this as WONTFIX.
Flags: needinfo?(bnicholson)
I would be fine with WONTFIX too. The extra search engines, if added by mistake, are easily removed.
Sounds good to me.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.