Build failure with clang: widget/gtkxtbin/gtk2xtbin.c error: void function 'xt_client_xloop_create' should not return a value

RESOLVED FIXED in mozilla17

Status

()

Core
Plug-ins
--
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: msucan, Assigned: msucan)

Tracking

({regression})

Trunk
mozilla17
x86_64
Linux
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I just pulled from the fx-team repository and I can no longer build Firefox.

Error:

gtk2xtbin.c
In file included from /home/mihai/src/mozilla/fx-team/widget/gtkxtbin/gtk2xtbin.c:1:
/home/mihai/src/mozilla/fx-team/widget/gtkxtbin/gtk2xtbin.c:480:8: error: void function 'xt_client_xloop_create' should not return a value [-Wreturn-type]
       return ((void*)0);
       ^      ~~~~~~~~~~
1 error generated.


Build information: I use ccache and clang from the Ubuntu 12.04 LTS repositories. Please let me know if further information is needed.

I am not sure, but it seems bug 544088 introduced this issue. I hope I am not mistaken.


Can someone please fix this? Thank you!

( I tried clobbering my build and clearing my ccache folder. No luck. )
(Assignee)

Comment 1

5 years ago
Created attachment 648359 [details] [diff] [review]
fix

With this change I can build Firefox.
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Attachment #648359 - Flags: review?(karlt)
Comment on attachment 648359 [details] [diff] [review]
fix

Reviewed by ted on IRC.
Attachment #648359 - Flags: review?(karlt) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8a5ec252311
g_source_new won't return NULL, so this code is never run anyway.
https://hg.mozilla.org/mozilla-central/rev/d8a5ec252311
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.