779857 - Build failure with clang: widget/gtkxtbin/gtk2xtbin.c error: void function 'xt_client_xloop_create' should not return a value

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Mihai Sucan [:msucan]]

I just pulled from the fx-team repository and I can no longer build Firefox.

Error:

gtk2xtbin.c
In file included from /home/mihai/src/mozilla/fx-team/widget/gtkxtbin/gtk2xtbin.c:1:
/home/mihai/src/mozilla/fx-team/widget/gtkxtbin/gtk2xtbin.c:480:8: error: void function 'xt_client_xloop_create' should not return a value [-Wreturn-type]
       return ((void*)0);
       ^      ~~~~~~~~~~
1 error generated.


Build information: I use ccache and clang from the Ubuntu 12.04 LTS repositories. Please let me know if further information is needed.

I am not sure, but it seems bug 544088 introduced this issue. I hope I am not mistaken.


Can someone please fix this? Thank you!

( I tried clobbering my build and clearing my ccache folder. No luck. )

Comment 1

[Mihai Sucan [:msucan]]

Attachment: fix

With this change I can build Firefox.

Comment 2

[Christian Holler (:decoder)]

Comment on attachment 648359 [details] [diff] [review]
fix

Reviewed by ted on IRC.

Comment 3

[Christian Holler (:decoder)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8a5ec252311

Comment 4

[Karl Tomlinson (:karlt)]

g_source_new won't return NULL, so this code is never run anyway.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d8a5ec252311