I just pulled from the fx-team repository and I can no longer build Firefox. Error: gtk2xtbin.c In file included from /home/mihai/src/mozilla/fx-team/widget/gtkxtbin/gtk2xtbin.c:1: /home/mihai/src/mozilla/fx-team/widget/gtkxtbin/gtk2xtbin.c:480:8: error: void function 'xt_client_xloop_create' should not return a value [-Wreturn-type] return ((void*)0); ^ ~~~~~~~~~~ 1 error generated. Build information: I use ccache and clang from the Ubuntu 12.04 LTS repositories. Please let me know if further information is needed. I am not sure, but it seems bug 544088 introduced this issue. I hope I am not mistaken. Can someone please fix this? Thank you! ( I tried clobbering my build and clearing my ccache folder. No luck. )
Created attachment 648359 [details] [diff] [review] fix With this change I can build Firefox.
Comment on attachment 648359 [details] [diff] [review] fix Reviewed by ted on IRC.
g_source_new won't return NULL, so this code is never run anyway.