Closed
Bug 779857
Opened 12 years ago
Closed 12 years ago
Build failure with clang: widget/gtkxtbin/gtk2xtbin.c error: void function 'xt_client_xloop_create' should not return a value
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: msucan, Assigned: msucan)
References
Details
(Keywords: regression)
Attachments
(1 file)
1015 bytes,
patch
|
decoder
:
review+
|
Details | Diff | Splinter Review |
I just pulled from the fx-team repository and I can no longer build Firefox. Error: gtk2xtbin.c In file included from /home/mihai/src/mozilla/fx-team/widget/gtkxtbin/gtk2xtbin.c:1: /home/mihai/src/mozilla/fx-team/widget/gtkxtbin/gtk2xtbin.c:480:8: error: void function 'xt_client_xloop_create' should not return a value [-Wreturn-type] return ((void*)0); ^ ~~~~~~~~~~ 1 error generated. Build information: I use ccache and clang from the Ubuntu 12.04 LTS repositories. Please let me know if further information is needed. I am not sure, but it seems bug 544088 introduced this issue. I hope I am not mistaken. Can someone please fix this? Thank you! ( I tried clobbering my build and clearing my ccache folder. No luck. )
Assignee | ||
Comment 1•12 years ago
|
||
With this change I can build Firefox.
Comment 2•12 years ago
|
||
Comment on attachment 648359 [details] [diff] [review] fix Reviewed by ted on IRC.
Attachment #648359 -
Flags: review?(karlt) → review+
Comment 4•12 years ago
|
||
g_source_new won't return NULL, so this code is never run anyway.
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d8a5ec252311
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•