Beginning on October 25th, 2016, Persona will no longer be an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 779857 - Build failure with clang: widget/gtkxtbin/gtk2xtbin.c error: void function 'xt_client_xloop_create' should not return a value
: Build failure with clang: widget/gtkxtbin/gtk2xtbin.c error: void function 'x...
: regression
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: Trunk
: x86_64 Linux
: -- critical (vote)
: mozilla17
Assigned To: Mihai Sucan [:msucan]
: Benjamin Smedberg [:bsmedberg]
Depends on: 544088
  Show dependency treegraph
Reported: 2012-08-02 08:18 PDT by Mihai Sucan [:msucan]
Modified: 2012-08-02 19:09 PDT (History)
5 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix (1015 bytes, patch)
2012-08-02 08:50 PDT, Mihai Sucan [:msucan]
choller: review+
Details | Diff | Splinter Review

Description Mihai Sucan [:msucan] 2012-08-02 08:18:22 PDT
I just pulled from the fx-team repository and I can no longer build Firefox.


In file included from /home/mihai/src/mozilla/fx-team/widget/gtkxtbin/gtk2xtbin.c:1:
/home/mihai/src/mozilla/fx-team/widget/gtkxtbin/gtk2xtbin.c:480:8: error: void function 'xt_client_xloop_create' should not return a value [-Wreturn-type]
       return ((void*)0);
       ^      ~~~~~~~~~~
1 error generated.

Build information: I use ccache and clang from the Ubuntu 12.04 LTS repositories. Please let me know if further information is needed.

I am not sure, but it seems bug 544088 introduced this issue. I hope I am not mistaken.

Can someone please fix this? Thank you!

( I tried clobbering my build and clearing my ccache folder. No luck. )
Comment 1 Mihai Sucan [:msucan] 2012-08-02 08:50:25 PDT
Created attachment 648359 [details] [diff] [review]

With this change I can build Firefox.
Comment 2 Christian Holler (:decoder) 2012-08-02 09:05:48 PDT
Comment on attachment 648359 [details] [diff] [review]

Reviewed by ted on IRC.
Comment 3 Christian Holler (:decoder) 2012-08-02 09:06:00 PDT
Comment 4 Karl Tomlinson (:karlt) 2012-08-02 14:29:40 PDT
g_source_new won't return NULL, so this code is never run anyway.
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-08-02 19:09:03 PDT

Note You need to log in before you can comment on or make changes to this bug.