Closed
Bug 780020
Opened 14 years ago
Closed 14 years ago
IonMonkey: Unbox int/bool more quickly in GetPropertyCacheT on x86_64.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sstangl, Unassigned)
References
Details
(Whiteboard: [ion:t])
Attachments
(1 file)
|
3.76 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
Loading an integer from a GetPropertyCacheT on x86_64 involves a 64-bit constant move, a 64-bit memory load, and a 64-bit and. This patch makes it a movl.
Attachment #648533 -
Flags: review?(nicolas.b.pierron)
|
||
Updated•14 years ago
|
Whiteboard: [ion:t]
|
||
Comment 1•14 years ago
|
||
Comment on attachment 648533 [details] [diff] [review]
patch
Review of attachment 648533 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/arm/MacroAssembler-arm.cpp
@@ +2157,5 @@
> ma_mov(operand.payloadReg(), dest);
> }
> +
> +void
> +MacroAssemblerARMCompat::unboxBoolean(const Address &src, const Register &dest)
nit: The review view reports extra trailing whitespace above this function.
Attachment #648533 -
Flags: review?(nicolas.b.pierron) → review+
|
Reporter | |
Comment 2•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•