The default bug view has changed. See this FAQ.

IonMonkey: Unbox int/bool more quickly in GetPropertyCacheT on x86_64.

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sstangl, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ion:t])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 648533 [details] [diff] [review]
patch

Loading an integer from a GetPropertyCacheT on x86_64 involves a 64-bit constant move, a 64-bit memory load, and a 64-bit and. This patch makes it a movl.
Attachment #648533 - Flags: review?(nicolas.b.pierron)
Whiteboard: [ion:t]
Comment on attachment 648533 [details] [diff] [review]
patch

Review of attachment 648533 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/arm/MacroAssembler-arm.cpp
@@ +2157,5 @@
>      ma_mov(operand.payloadReg(), dest);
>  }
> +    
> +void
> +MacroAssemblerARMCompat::unboxBoolean(const Address &src, const Register &dest)

nit: The review view reports extra trailing whitespace above this function.
Attachment #648533 - Flags: review?(nicolas.b.pierron) → review+
(Reporter)

Comment 2

5 years ago
http://hg.mozilla.org/projects/ionmonkey/rev/3d2f62ee2982
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Blocks: 796114
You need to log in before you can comment on or make changes to this bug.