Last Comment Bug 780020 - IonMonkey: Unbox int/bool more quickly in GetPropertyCacheT on x86_64.
: IonMonkey: Unbox int/bool more quickly in GetPropertyCacheT on x86_64.
Status: RESOLVED FIXED
[ion:t]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86_64 All
: -- normal (vote)
: ---
Assigned To: general
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks: 777583 796114
  Show dependency treegraph
 
Reported: 2012-08-02 16:05 PDT by Sean Stangl [:sstangl]
Modified: 2012-10-01 13:45 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (3.76 KB, patch)
2012-08-02 16:05 PDT, Sean Stangl [:sstangl]
nicolas.b.pierron: review+
Details | Diff | Splinter Review

Description Sean Stangl [:sstangl] 2012-08-02 16:05:17 PDT
Created attachment 648533 [details] [diff] [review]
patch

Loading an integer from a GetPropertyCacheT on x86_64 involves a 64-bit constant move, a 64-bit memory load, and a 64-bit and. This patch makes it a movl.
Comment 1 Nicolas B. Pierron [:nbp] 2012-08-06 13:04:48 PDT
Comment on attachment 648533 [details] [diff] [review]
patch

Review of attachment 648533 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/arm/MacroAssembler-arm.cpp
@@ +2157,5 @@
>      ma_mov(operand.payloadReg(), dest);
>  }
> +    
> +void
> +MacroAssemblerARMCompat::unboxBoolean(const Address &src, const Register &dest)

nit: The review view reports extra trailing whitespace above this function.
Comment 2 Sean Stangl [:sstangl] 2012-08-06 14:34:44 PDT
http://hg.mozilla.org/projects/ionmonkey/rev/3d2f62ee2982

Note You need to log in before you can comment on or make changes to this bug.