Closed Bug 780047 Opened 7 years ago Closed 7 years ago

Prevent mozbrowsers from using PBrowser:CreateWindow

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
blocking-basecamp +

People

(Reporter: cjones, Assigned: justin.lebar+bug)

References

Details

Attachments

(1 file)

This is a "legacy" interface we implemented for xul-fennec.  We should ensure that PBrowsers opened for mozbrowser treat those requests as malicious attacks.

Should block because I'm pretty sure OpenWindow is fully trusted and would allow bad things to happen ...
blocking-basecamp: ? → +
Justin, could you be the owner here?
Assignee: nobody → justin.lebar+bug
Chris, there is no PBrowser::OpenWindow, nor did such a method ever exist, as far as I can tell.

Can you help me find the method you're referring to here?
http://mxr.mozilla.org/mozilla-central/source/dom/ipc/PBrowser.ipdl#79
Summary: Prevent mozbrowsers from using PBrowser:OpenWindow → Prevent mozbrowsers from using PBrowser:CreateWindow
Attached patch Patch, v1Splinter Review
Attachment #655824 - Flags: review?(jones.chris.g)
Comment on attachment 655824 [details] [diff] [review]
Patch, v1

Now that xul-fennec is de-supported, I'd love to take a hatchet to this.  Except I think metro inherited all that code.

All the same, filing a followup on excising this would make me happy.
Attachment #655824 - Flags: review?(jones.chris.g) → review+
https://hg.mozilla.org/mozilla-central/rev/e6cc3b189dcf
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Component: DOM: Apps → IPC
You need to log in before you can comment on or make changes to this bug.