Some input stream types cannot be transferred via IPC

RESOLVED FIXED in mozilla17

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ben Turner (not reading bugmail, use the needinfo flag!), Assigned: Ben Turner (not reading bugmail, use the needinfo flag!))

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 648579 [details] [diff] [review]
Patch, v1

My IPC blob tests reveal two kinds of blob input streams that are currently triggering main thread copies. Patch attached fixes both.
Attachment #648579 - Flags: review?(khuey)
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Comment on attachment 648579 [details] [diff] [review]
Patch, v1

Review of attachment 648579 [details] [diff] [review]:
-----------------------------------------------------------------

I may be wrong, but there's no need to implement nsIClassInfo on DataOwnerAdapter, right?  Just hand out the pointer you have for it.
Attachment #648579 - Flags: review?(khuey) → review-
Comment on attachment 648579 [details] [diff] [review]
Patch, v1

Review of attachment 648579 [details] [diff] [review]:
-----------------------------------------------------------------

bent convinced me that's not important.
Attachment #648579 - Flags: review- → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/21d92e8dd85a

Comment 4

5 years ago
Backed out for compilation failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=21d92e8dd85a

https://hg.mozilla.org/integration/mozilla-inbound/rev/21d92e8dd85a

Comment 5

5 years ago
(In reply to Ed Morley [:edmorley] from comment #4)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/21d92e8dd85a

Sorry, meant https://hg.mozilla.org/integration/mozilla-inbound/rev/c206e3d4a533
Crapo. That's the bug about XPIDL generating bad macros... Lame.

Fixed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec210ececc2c

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ec210ececc2c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.