780048 - Some input stream types cannot be transferred via IPC

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

My IPC blob tests reveal two kinds of blob input streams that are currently triggering main thread copies. Patch attached fixes both.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 648579 [details] [diff] [review]
Patch, v1

Review of attachment 648579 [details] [diff] [review]:
-----------------------------------------------------------------

I may be wrong, but there's no need to implement nsIClassInfo on DataOwnerAdapter, right?  Just hand out the pointer you have for it.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 648579 [details] [diff] [review]
Patch, v1

Review of attachment 648579 [details] [diff] [review]:
-----------------------------------------------------------------

bent convinced me that's not important.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21d92e8dd85a

Comment 4

[Ed Morley [:emorley]]

Backed out for compilation failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=21d92e8dd85a

https://hg.mozilla.org/integration/mozilla-inbound/rev/21d92e8dd85a

Comment 5

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley] from comment #4)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/21d92e8dd85a

Sorry, meant https://hg.mozilla.org/integration/mozilla-inbound/rev/c206e3d4a533

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Crapo. That's the bug about XPIDL generating bad macros... Lame.

Fixed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec210ececc2c

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ec210ececc2c