780066 - The wifi function doesn't work if the wifi setttings is disabled after rebooting the device.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Vincent Chang[:vchang][changyihsin]]

Test Procedure, 
1. Turn off the wifi in the settings. 
2. reboot the device. 
3. Try to turn on the wifi in the settings.
The result:  
Keep on seeing the "Searching..." in Available Networks. 

The root cause: 
I found that WifiWorker will enable the wifi by calling WifiManager.setWifiEnabled function in constructor function. However, it is turned off because wifi is disabled in settings. So manager.state will be set to DISCONNECTED state. However, the connectToSupplicant function will only be called when manager.state is in UNINITIALIZED state when calling manager.start function.

Comment 1

[Vincent Chang[:vchang][changyihsin]]

Attachment: WIP

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 648609 [details] [diff] [review]
WIP

This feels wrong to me. It feels like there should be an approach here that actually fixes the logic somewhere, rather than avoiding the situation entirely.

I think I have a patch on my other computer that fixes this. I'll attach it in a few minutes.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Possible fix?

Vincent, can you try this and see if it fixes things for you?

Comment 4

[Vincent Chang[:vchang][changyihsin]]

(In reply to Blake Kaplan (:mrbkap) from comment #3)
> Created attachment 649922 [details] [diff] [review]
> Possible fix?
> 
> Vincent, can you try this and see if it fixes things for you?

I have verified this patch. It works fine for me.

Comment 5

[Vincent Chang[:vchang][changyihsin]]

(In reply to Blake Kaplan (:mrbkap) from comment #2)
> Comment on attachment 648609 [details] [diff] [review]
> WIP
> 
> This feels wrong to me. It feels like there should be an approach here that
> actually fixes the logic somewhere, rather than avoiding the situation
> entirely.
> 
> I think I have a patch on my other computer that fixes this. I'll attach it
> in a few minutes.

Do we still need to call WifiManager.setWifiEnabled in the beginning ?

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/mozilla-central/rev/8afba7332d77

For comment 5, I don't think we do anymore, but we can leave it for now, since bug 729877 should land sometime soon.