default value of android version should be 9 on x86 or mipsel

RESOLVED FIXED in mozilla17

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla17
x86
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
min version of NDK is 9 on x86 or mips.
(In reply to Makoto Kato from comment #0)
> min version of NDK is 9 on x86 or mips.

Why? I've build for both with a earlier NDKs. (r6 or r7 for x86, and r8 for mips)
(Assignee)

Comment 2

5 years ago
(In reply to Mike Hommey [:glandium] from comment #1)
> (In reply to Makoto Kato from comment #0)
> > min version of NDK is 9 on x86 or mips.
> 
> Why? I've build for both with a earlier NDKs. (r6 or r7 for x86, and r8 for
> mips)

This means that android 2.3.4 or later, not NDK version.
(Assignee)

Comment 3

5 years ago
x86 and mips is API 9 or later.  (platforms/android-<android api version> in NDK)
Ah, android_version, not NDK version.
(Assignee)

Comment 5

5 years ago
Created attachment 648636 [details] [diff] [review]
fix
Attachment #648636 - Flags: review?(mh+mozilla)
Comment on attachment 648636 [details] [diff] [review]
fix

Review of attachment 648636 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/autoconf/android.m4
@@ +19,5 @@
> +case "$target_cpu" in
> +arm)
> +    android_version=5
> +    ;;
> +i?86)

Make that i?86|mipsel)

@@ +30,4 @@
>  
>  MOZ_ARG_WITH_STRING(android-version,
>  [  --with-android-version=VER
>                            android platform version, default 5],

Please change the help string (note you can't use the variable there, so just put something like "5 for arm, 9 for x86/mips")

r+ with these changes.
Attachment #648636 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ae5f9ed9a33
Target Milestone: --- → mozilla17

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/9ae5f9ed9a33
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.