780072 - default value of android version should be 9 on x86 or mipsel

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato]]

min version of NDK is 9 on x86 or mips.

Comment 1

[Mike Hommey [:glandium]]

(In reply to Makoto Kato from comment #0)
> min version of NDK is 9 on x86 or mips.

Why? I've build for both with a earlier NDKs. (r6 or r7 for x86, and r8 for mips)

Comment 2

[Makoto Kato [:m_kato]]

(In reply to Mike Hommey [:glandium] from comment #1)
> (In reply to Makoto Kato from comment #0)
> > min version of NDK is 9 on x86 or mips.
> 
> Why? I've build for both with a earlier NDKs. (r6 or r7 for x86, and r8 for
> mips)

This means that android 2.3.4 or later, not NDK version.

Comment 3

[Makoto Kato [:m_kato]]

x86 and mips is API 9 or later.  (platforms/android-<android api version> in NDK)

Comment 4

[Mike Hommey [:glandium]]

Ah, android_version, not NDK version.

Comment 5

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 648636 [details] [diff] [review]
fix

Review of attachment 648636 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/autoconf/android.m4
@@ +19,5 @@
> +case "$target_cpu" in
> +arm)
> +    android_version=5
> +    ;;
> +i?86)

Make that i?86|mipsel)

@@ +30,4 @@
>  
>  MOZ_ARG_WITH_STRING(android-version,
>  [  --with-android-version=VER
>                            android platform version, default 5],

Please change the help string (note you can't use the variable there, so just put something like "5 for arm, 9 for x86/mips")

r+ with these changes.

Comment 7

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ae5f9ed9a33

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9ae5f9ed9a33