Last Comment Bug 780072 - default value of android version should be 9 on x86 or mipsel
: default value of android version should be 9 on x86 or mipsel
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86 Android
: -- normal (vote)
: mozilla17
Assigned To: Makoto Kato [:m_kato]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-02 23:34 PDT by Makoto Kato [:m_kato]
Modified: 2012-08-06 07:42 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (2.17 KB, patch)
2012-08-03 00:09 PDT, Makoto Kato [:m_kato]
mh+mozilla: review+
Details | Diff | Splinter Review

Description Makoto Kato [:m_kato] 2012-08-02 23:34:32 PDT
min version of NDK is 9 on x86 or mips.
Comment 1 Mike Hommey [:glandium] 2012-08-02 23:52:12 PDT
(In reply to Makoto Kato from comment #0)
> min version of NDK is 9 on x86 or mips.

Why? I've build for both with a earlier NDKs. (r6 or r7 for x86, and r8 for mips)
Comment 2 Makoto Kato [:m_kato] 2012-08-03 00:05:34 PDT
(In reply to Mike Hommey [:glandium] from comment #1)
> (In reply to Makoto Kato from comment #0)
> > min version of NDK is 9 on x86 or mips.
> 
> Why? I've build for both with a earlier NDKs. (r6 or r7 for x86, and r8 for
> mips)

This means that android 2.3.4 or later, not NDK version.
Comment 3 Makoto Kato [:m_kato] 2012-08-03 00:06:46 PDT
x86 and mips is API 9 or later.  (platforms/android-<android api version> in NDK)
Comment 4 Mike Hommey [:glandium] 2012-08-03 00:09:12 PDT
Ah, android_version, not NDK version.
Comment 5 Makoto Kato [:m_kato] 2012-08-03 00:09:22 PDT
Created attachment 648636 [details] [diff] [review]
fix
Comment 6 Mike Hommey [:glandium] 2012-08-03 00:12:34 PDT
Comment on attachment 648636 [details] [diff] [review]
fix

Review of attachment 648636 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/autoconf/android.m4
@@ +19,5 @@
> +case "$target_cpu" in
> +arm)
> +    android_version=5
> +    ;;
> +i?86)

Make that i?86|mipsel)

@@ +30,4 @@
>  
>  MOZ_ARG_WITH_STRING(android-version,
>  [  --with-android-version=VER
>                            android platform version, default 5],

Please change the help string (note you can't use the variable there, so just put something like "5 for arm, 9 for x86/mips")

r+ with these changes.
Comment 8 Ed Morley [:emorley] 2012-08-06 07:42:45 PDT
https://hg.mozilla.org/mozilla-central/rev/9ae5f9ed9a33

Note You need to log in before you can comment on or make changes to this bug.