780107 - Mozmill does not dismiss popups of bookmarks toolbar after click

Status: RESOLVED WONTFIX

(Testing Graveyard :: Mozmill, defect)

Description

[Maniac Vlad Florin (:vladmaniac)]

Attachment: [mozmill endurance test] test we do not dismiss menus after click

We should dismiss menus after clicking on them

The endurance test uploaded under attachments demonstrates we are currently not doing this

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Vlad: Can you reduce the test case to the bare minimum. All it should need to do is open a menu and click a menu item. Ideally it would assert that the menu is no longer visible too, and therefore will be a good test for verifying a fix.

Also, could you try replicating this in Mozmill 2.0 to see if it's affected?

Comment 2

[Maniac Vlad Florin (:vladmaniac)]

Attachment: simplified testcase

simplified testcase with assert for 'hidden' javascript property of the menu
currently fails since we have this bug 

Dave, can you please feedback this please?

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 648666 [details]
simplified testcase

You shouldn't need the places and tabs imports. Drop the license block too as this is just a minimised test case. For me this fails to locate the getting started element.

Seeing the mouseDown/mouseUp makes me wonder if that would correctly dismiss the menu. Could you try it?

Comment 4

[Maniac Vlad Florin (:vladmaniac)]

(In reply to Dave Hunt (:davehunt) from comment #3)
> Comment on attachment 648666 [details]
> simplified testcase
> 
> You shouldn't need the places and tabs imports. Drop the license block too
> as this is just a minimised test case. For me this fails to locate the
> getting started element.

I can't explain this. For me it behaves normally. Can you please paste the error, Firefox version? I suspect you tried OS X, right?

> 
> Seeing the mouseDown/mouseUp makes me wonder if that would correctly dismiss
> the menu. Could you try it?

mouseDown/mouseUp has nothing to do with the menus and it does not work. That is to toggle the bookmarks toolbar. I used that because its very easy to see the defect in that context.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sounds invalid to me. That's exactly what the Menu API has to be used for. Also keep in mind that the items in the bookmarks toolbar behave differently on mouse events as other elements in the Firefox UI.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Henrik Skupin (:whimboo) [away 07/27 - 08/05] from comment #5)
> Sounds invalid to me. That's exactly what the Menu API has to be used for.
> Also keep in mind that the items in the bookmarks toolbar behave differently
> on mouse events as other elements in the Firefox UI.

This is related to an endurance test where we want to simulate user interactions rather than trigger APIs. Currently clicking on a bookmark within a bookmark folder from the bookmark toolbar does not dismiss the menu as I would expect. Clint also suspected this may be a Mozmill defect in bug 705284 comment 73.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So lets re-evaluate that. It's a popup of the bookmarks toolbar. Then it makes sense. I don't think that this will block any 1.5.x release.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Vlad, please create a real minimized testcase without any external dependency. Further test with Mozmill 2.0 as Dave has suggested 4 days ago.

Comment 9

[Maniac Vlad Florin (:vladmaniac)]

Attachment: simplified testcase v2.0

* the testcase has no external dependencies

Comment 10

[Maniac Vlad Florin (:vladmaniac)]

(In reply to Henrik Skupin (:whimboo) from comment #8)
> Vlad, please create a real minimized testcase without any external
> dependency. Further test with Mozmill 2.0 as Dave has suggested 4 days ago.

I will have to get back re Mozmill 2.0 after I install it

Comment 11

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Any updates here? Do you need assistance getting Mozmill 2.0 installed?

Comment 12

[Maniac Vlad Florin (:vladmaniac)]

(In reply to Dave Hunt (:davehunt) from comment #11)
> Any updates here? Do you need assistance getting Mozmill 2.0 installed?

Sorry for not giving any updates yet. I've installed Mozmill 2.0 following this history of commands (pasting here so you can correct if I missed anything)

git clone https://github.com/mozilla/mozbase.git
git clone https://github.com/mozilla/mozmill.git
cd mozbase
sudo python setup_development.py
cd ../mozmill
sudo python setup_development.py 

I got some strange errors and somehow missed to paste them in the bug, let me test again in the meantime

Comment 13

[Maniac Vlad Florin (:vladmaniac)]

I get 

TEST-UNEXPECTED-FAIL | /home/vladmaniac/Desktop/testcase/mozmill-tests/tests/functional/test1.js | testMenus
INFO | [JavaScript Error: "Error: could not find element Selector: .bookmark-item[label='Getting Started']" {file: "resource://mozmill/modules/frame.js" line: 650}]

with Mozmill 2.0

Comment 14

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I think you just need to wait for the element to be present.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Given hat we had no follow-up from Vlad on this bug re Mozmill 2.0 we don't know what the outcome is. As workaround we can hit Esc for now. Not going to block 1.5.18 on it.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozmill will reach its end of life soon. We are currently working on getting all the tests for Firefox ported to Marionette. For status updates please see bug 1080766.