Last Comment Bug 780111 - Share code with new DOM bindings for primitive conversions in XPCConvert::JSData2Native
: Share code with new DOM bindings for primitive conversions in XPCConvert::JSD...
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla17
Assigned To: :Ms2ger (⌚ UTC+1/+2)
: Andrew Overholt [:overholt]
Depends on:
  Show dependency treegraph
Reported: 2012-08-03 04:23 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-08-04 18:41 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (4.26 KB, patch)
2012-08-03 04:23 PDT, :Ms2ger (⌚ UTC+1/+2)
bobbyholley: review+
Details | Diff | Splinter Review

Description User image :Ms2ger (⌚ UTC+1/+2) 2012-08-03 04:23:01 PDT
Created attachment 648663 [details] [diff] [review]
Patch v1

If only because you can bet that bz will make that code as fast as possible.
Comment 1 User image Bobby Holley (:bholley) (busy with Stylo) 2012-08-03 04:55:22 PDT
Comment on attachment 648663 [details] [diff] [review]
Patch v1

Hell yeah. I haven't looked much at the implementations in PrimitiveConversions.h, but assuming they work this looks great!
Comment 2 User image :Ms2ger (⌚ UTC+1/+2) 2012-08-04 01:51:28 PDT
Comment 3 User image Ed Morley [:emorley] 2012-08-04 11:30:07 PDT
Backed out with the mass tree revert to get rid of the OS X M5 orange:
Comment 4 User image Ryan VanderMeulen [:RyanVM] 2012-08-04 13:34:55 PDT
Comment 5 User image Ryan VanderMeulen [:RyanVM] 2012-08-04 18:41:51 PDT

Note You need to log in before you can comment on or make changes to this bug.