Make nsAttrAndChildArray::GetModifiableMapped infallible

RESOLVED FIXED in mozilla17

Status

()

Product:
Core
Component:
DOM
RESOLVED FIXED
Reported:
5 years ago
Modified:
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Version:
Trunk
Target:
mozilla17
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Patch v1
6.83 KB, patch
bz
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
5 years ago 
Created attachment 648713 [details] [diff] [review]
Patch v1
Attachment #648713 - Flags: review?(bzbarsky)

Comment 1

•
5 years ago 
Comment on attachment 648713 [details] [diff] [review]
Patch v1

Please either document that GetModifiableMapped acts like operator new (returns a 0-refcount object) or just switch it to returing already_AddRefed.

r=me with that.
Attachment #648713 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

•
5 years ago 
Documented.

https://hg.mozilla.org/mozilla-central/rev/20fc34efd733
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17

Comment 3

•
5 years ago 
Backed out with the mass tree revert to get rid of the OS X M5 orange:
https://hg.mozilla.org/mozilla-central/rev/c801b99d726f
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 4

•
5 years ago 
https://hg.mozilla.org/integration/mozilla-inbound/rev/f001138cae47
Flags: in-testsuite-

Comment 5

•
5 years ago 
https://hg.mozilla.org/mozilla-central/rev/f001138cae47
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago → 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.