Last Comment Bug 780164 - Make nsAttrAndChildArray::GetModifiableMapped infallible
: Make nsAttrAndChildArray::GetModifiableMapped infallible
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-03 08:24 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-08-04 18:40 PDT (History)
1 user (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (6.83 KB, patch)
2012-08-03 08:24 PDT, :Ms2ger (⌚ UTC+1/+2)
bzbarsky: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-08-03 08:24:35 PDT
Created attachment 648713 [details] [diff] [review]
Patch v1
Comment 1 Boris Zbarsky [:bz] 2012-08-03 12:11:44 PDT
Comment on attachment 648713 [details] [diff] [review]
Patch v1

Please either document that GetModifiableMapped acts like operator new (returns a 0-refcount object) or just switch it to returing already_AddRefed.

r=me with that.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-08-04 02:00:15 PDT
Documented.

https://hg.mozilla.org/mozilla-central/rev/20fc34efd733
Comment 3 Ed Morley [:emorley] 2012-08-04 11:28:02 PDT
Backed out with the mass tree revert to get rid of the OS X M5 orange:
https://hg.mozilla.org/mozilla-central/rev/c801b99d726f
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-08-04 14:52:01 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/f001138cae47
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-08-04 18:40:13 PDT
https://hg.mozilla.org/mozilla-central/rev/f001138cae47

Note You need to log in before you can comment on or make changes to this bug.