780164 - Make nsAttrAndChildArray::GetModifiableMapped infallible

Status: RESOLVED FIXED

Description

[:Ms2ger (⌚ UTC+1/+2)]

Created attachment 648713 [details] [diff] [review]
Patch v1

Comment 1

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

Comment on attachment 648713 [details] [diff] [review]
Patch v1

Please either document that GetModifiableMapped acts like operator new (returns a 0-refcount object) or just switch it to returing already_AddRefed.

r=me with that.

Comment 2

[:Ms2ger (⌚ UTC+1/+2)]

Documented.

https://hg.mozilla.org/mozilla-central/rev/20fc34efd733

Comment 3

[Ed Morley [:emorley]]

Backed out with the mass tree revert to get rid of the OS X M5 orange:
https://hg.mozilla.org/mozilla-central/rev/c801b99d726f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f001138cae47

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f001138cae47