Closed Bug 780164 Opened 9 years ago Closed 9 years ago

Make nsAttrAndChildArray::GetModifiableMapped infallible

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla17

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file)

Patch v1
6.83 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Attached patch Patch v1 — — Splinter Review 
No description provided.
Attachment #648713 - Flags: review?(bzbarsky)
Comment on attachment 648713 [details] [diff] [review]
Patch v1

Please either document that GetModifiableMapped acts like operator new (returns a 0-refcount object) or just switch it to returing already_AddRefed.

r=me with that.
Attachment #648713 - Flags: review?(bzbarsky) → review+
Documented.

https://hg.mozilla.org/mozilla-central/rev/20fc34efd733
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Backed out with the mass tree revert to get rid of the OS X M5 orange:
https://hg.mozilla.org/mozilla-central/rev/c801b99d726f
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/f001138cae47
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.