Closed
Bug 780185
Opened 12 years ago
Closed 10 years ago
Turn on frame pointers on Nightly builds (--enable-profiling)
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philip.chee, Assigned: ewong)
Details
Attachments
(1 file, 1 obsolete file)
2.94 KB,
patch
|
ewong
:
review+
|
Details | Diff | Splinter Review |
We should turn on frame pointers on Nightly builds (--enable-profiling) so we can do profiling with the built-in profiler. See: https://groups.google.com/group/mozilla.dev.platform/browse_thread/thread/504366c143850a45# https://developer.mozilla.org/en/Performance/Profiling_with_the_Built-in_Profiler
Reporter | ||
Comment 1•12 years ago
|
||
And Firefox Bug 764216 - Turn on frame pointers on Nightly desktop builds
Assignee | ||
Comment 2•12 years ago
|
||
Comment 3•12 years ago
|
||
Comment on attachment 648932 [details] [diff] [review] Turn on frame pointers on Nightly Builds. (--enable-profiling) (v1) Review of attachment 648932 [details] [diff] [review]: ----------------------------------------------------------------- So based on reading https://groups.google.com/forum/#!topic/mozilla.dev.platform/UENmwUOFCkU and the stuff in Bug 764216 I'm going to WONTFIX this, however I am entirely *willing* to turn it on if someone is wanting/willing to do profiling/perf testing and investigation for SeaMonkey.
Attachment #648932 -
Flags: review?(bugspam.Callek) → review-
Comment 4•12 years ago
|
||
per c#3 WONTFIX, if someone wants to commit to doing said perf testing/investigation, I'll be happy to take this though
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Resolution: FIXED → WONTFIX
Finished performance and build time investigation, no negative affection detected. Test system: Intel Pentium E2160 (1.8 GHz), 1 GB RAM --------------------------- Build time Profiling: 02:59:20 Regular: 03:00:47 --------------------------- SunSpider Profiling: Total: 501.5ms +/- 14.8% Total: 449.8ms +/- 1.9% Total: 442.2ms +/- 1.1% Regular: Total: 458.9ms +/- 5.4% Total: 438.4ms +/- 0.7% Total: 443.9ms +/- 1.4% --------------------------- Google Profiling: Score: 4203 Score: 4187 Score: 4157 Regular: Score: 4257 Score: 4116 Score: 4103 --------------------------- Futuremark Peacekeeper Profiling: 854 Regular: 856
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Attachment #648932 -
Flags: review- → review?(bugspam.Callek)
Comment 6•12 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #4) > per c#3 WONTFIX, if someone wants to commit to doing said perf > testing/investigation, I'll be happy to take this though (In reply to Phoenix from comment #5) > Finished performance and build time investigation, no negative affection > detected. For the record, the people at Mozilla who designed this flag claim it does affect performance negatively, and visibly in most cases. So forgive me if I discard the base claims here [for now. That said, are you committing to improving SeaMonkey specific performance issues in a way that would be benefited by adding this flag? [since it also has overhead for when we migrate branches, do a release, etc. in making sure we remove the flag at the appropriate time] If you are can you give me an idea on what is helped specifically by us adding it?
(In reply to Justin Wood (:Callek) from comment #6) > If you are can you give me an > idea on what is helped specifically by us adding it? The main goal is to make Gecko Profiling Addon work in SeaMonkey https://github.com/bgirard/Gecko-Profiler-Addon http://benoitgirard.wordpress.com/2012/07/27/javascript-profiling-with-the-gecko-profiler-and-js-anti-pattern/ It can help users to determine the source of performance problem faster, than in wild guessing case. Fresh example of such thread in Mozillazine: http://forums.mozillazine.org/viewtopic.php?f=40&t=2543177
Assignee | ||
Updated•11 years ago
|
Assignee: ewong → nobody
Status: REOPENED → NEW
Reporter | ||
Comment 8•10 years ago
|
||
http://logs.glob.uno/?c=mozilla%23seamonkey&a=date&s=Yesterday&e=Today&h=#c621328 19:18 * Px also sticks a pin to Callek's doll for bug 780185 19:21 RattyAway "For the record, the people at Mozilla who designed this flag claim it does affect performance negatively, and visibly in most cases. So forgive me if I discard the base claims here [for now." 19:21 RattyAway I understand that the performance regressions have all been fixed. 19:21 RattyAway Callek: could we have your r+ now? 19:21 Callek RattyAway: stamp+ 19:22 RattyAway Callek: thanks
Flags: needinfo?(ewong)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Flags: needinfo?(ewong)
Assignee | ||
Comment 9•10 years ago
|
||
Attachment #648932 -
Attachment is obsolete: true
Attachment #648932 -
Flags: review?(bugspam.Callek)
Attachment #8450691 -
Flags: review+
Assignee | ||
Comment 10•10 years ago
|
||
Pushed to comm-central: https://hg.mozilla.org/comm-central/rev/32b8c18a0abf
Status: ASSIGNED → RESOLVED
Closed: 12 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•