780203 - add some stdint types to xpidl

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: patch

This adds [u]intn_t types to xpidl that map to the c++ type by the same name, which should help us move towards more stdint types (hopefully)

I didn't add a int8_t type because xpidl doesn't have a signed 8 bit type, and I sort of figure if we haven't needed it yet its not worth bothering with, but if you like I could try.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 648761 [details] [diff] [review]
patch

Review of attachment 648761 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/idl-parser/typelib.py
@@ +23,5 @@
> +    'int64_t':          xpt.Type.Tags.int64,
> +    'uint8_t':              xpt.Type.Tags.uint8,
> +    'uint16_t':     xpt.Type.Tags.uint16,
> +    'uint32_t':      xpt.Type.Tags.uint32,
> +    'uint64_t': xpt.Type.Tags.uint64,

What's up with the goofy formatting here?

Comment 3

[Trevor Saunders (:tbsaunde)]

(In reply to Ted Mielczarek [:ted] from comment #2)
> Comment on attachment 648761 [details] [diff] [review]
> patch
> 
> Review of attachment 648761 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: xpcom/idl-parser/typelib.py
> @@ +23,5 @@
> > +    'int64_t':          xpt.Type.Tags.int64,
> > +    'uint8_t':              xpt.Type.Tags.uint8,
> > +    'uint16_t':     xpt.Type.Tags.uint16,
> > +    'uint32_t':      xpt.Type.Tags.uint32,
> > +    'uint64_t': xpt.Type.Tags.uint64,
> 
> What's up with the goofy formatting here?

I have no idea, my best guess is that I screwed it up somehow and didn't notice because of screen reader not being setup to read whitespace by default, and of course that I forgot to check manually :(

Comment 4

[Trevor Saunders (:tbsaunde)]

Attachment: patch v2

make whitespace nicer.

Comment 5

[Trevor Saunders (:tbsaunde)]

landed https://hg.mozilla.org/integration/mozilla-inbound/rev/4bdc7b03597e

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4bdc7b03597e

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Somehow the goofy formatting got landed :(

Comment 8

[Trevor Saunders (:tbsaunde)]

ugh
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3422c4a00b4

Comment 9

[(no longer active)]

Ah, can we back this out please?  This will break what I have in bug 579517.  This will be fixed when those patches land.

Comment 10

[(no longer active)]

Sigh.  I think I'll have to rebase my work on top of this.  :(

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e3422c4a00b4

Comment 12

[Trevor Saunders (:tbsaunde)]

(In reply to Ehsan Akhgari [:ehsan] from comment #9)
> Ah, can we back this out please?  This will break what I have in bug 579517.
> This will be fixed when those patches land.

if you haven't already rebased on top of it I guess so.

Comment 13

[Trevor Saunders (:tbsaunde)]

(In reply to Ehsan Akhgari [:ehsan] from comment #10)
> Sigh.  I think I'll have to rebase my work on top of this.  :(

sorry, I didn't respond earlier I was out all afternoon.

Comment 14

[(no longer active)]

No problem, turns out that this doesn't hurt my work :-)