Last Comment Bug 780210 - B2G pinching-to-zoom is using an incorrect focus point
: B2G pinching-to-zoom is using an incorrect focus point
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics: Layers (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Doug Sherk (:drs) (inactive)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-03 10:29 PDT by Doug Sherk (:drs) (inactive)
Modified: 2012-08-09 04:52 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix B2G focus point calculation for pinching (1.62 KB, patch)
2012-08-03 10:35 PDT, Doug Sherk (:drs) (inactive)
bugmail: review+
Details | Diff | Splinter Review

Description Doug Sherk (:drs) (inactive) 2012-08-03 10:29:18 PDT
When zoomed in very heavily (in either the outwards or inwards direction), pinching is not aligning itself to the focus point correctly.
Comment 1 Doug Sherk (:drs) (inactive) 2012-08-03 10:35:33 PDT
Created attachment 648766 [details] [diff] [review]
Fix B2G focus point calculation for pinching

Proposed fix
Comment 2 Kartikaya Gupta (email:kats@mozilla.com) 2012-08-05 08:01:23 PDT
Comment on attachment 648766 [details] [diff] [review]
Fix B2G focus point calculation for pinching

Review of attachment 648766 [details] [diff] [review]:
-----------------------------------------------------------------

If it works, fine by me.
Comment 3 Doug Sherk (:drs) (inactive) 2012-08-07 18:53:10 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/36832ad5ea65
Comment 4 Phil Ringnalda (:philor) 2012-08-07 21:08:00 PDT
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/d8878c0bd67c - something in that push made Linux oddly unhappy.
Comment 5 Ed Morley [:emorley] 2012-08-08 09:29:51 PDT
https://hg.mozilla.org/mozilla-central/rev/36832ad5ea65
Comment 6 Doug Sherk (:drs) (inactive) 2012-08-08 11:04:10 PDT
This was backed out.
Comment 7 Doug Sherk (:drs) (inactive) 2012-08-08 13:39:50 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ff614eb788d
Comment 8 Ed Morley [:emorley] 2012-08-09 04:52:38 PDT
https://hg.mozilla.org/mozilla-central/rev/0ff614eb788d

Note You need to log in before you can comment on or make changes to this bug.