Closed
Bug 780212
Opened 13 years ago
Closed 13 years ago
Fix buffer overflow beyond MAXPATHLEN when querying Android's GRE_HOME
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox17 fixed)
RESOLVED
FIXED
Firefox 17
| Tracking | Status | |
|---|---|---|
| firefox17 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
Details
Attachments
(1 file)
|
863 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
This compiler warning points to a buffer overflow beyond MAXPATHLEN when querying Android's GRE_HOME:
mozilla/central/xpcom/build/BinaryPath.h: In function 'nsresult XRE_GetBinaryPath(const char*, nsIFile**)':
mozilla/central/xpcom/build/BinaryPath.h:79: warning: array subscript is above array bounds
Attachment #648764 -
Flags: review?(mh+mozilla)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 648764 [details] [diff] [review]
fix-GRE_HOME_overflow.patch
Review of attachment 648764 [details] [diff] [review]:
-----------------------------------------------------------------
While you're here, can you fix the XP_UNIX part, which doesn't have that guard at all?
Attachment #648764 -
Flags: review?(mh+mozilla) → review+
|
|
||
Comment 2•13 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #1)
> Comment on attachment 648764 [details] [diff] [review]
> fix-GRE_HOME_overflow.patch
>
> Review of attachment 648764 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> While you're here, can you fix the XP_UNIX part, which doesn't have that
> guard at all?
Actually, it doesn't need it afaics.
|
Assignee | |
Comment 3•13 years ago
|
||
status-firefox17:
--- → fixed
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•