780278 - Sidebar "Tabs" dropdown doesn't display properly on Linux

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[[e-mail]]

Toolkit defines a 25px height for the sidebarheader element on both Linux and Windows. This is OK on Windows, because that's the default height of our sidebarheader anyway. However, on Linux, this height isn't enough to display a menubutton correctly. I don't want to change toolkit because there are people using sidebarheader all over the shop.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Philip Chee]

Comment on attachment 648849 [details] [diff] [review]
Proposed patch

> Toolkit defines a 25px height for the sidebarheader element on both Linux and
> Windows. This is OK on Windows, because that's the default height of our
> sidebarheader anyway. However, on Linux, this height isn't enough to display a
> menubutton correctly. I don't want to change toolkit because there are people
> using sidebarheader all over the shop.

In Windows7 Classic theme, the height is 25px with or without your patch.
In Windows7 Aero theme, the height jumps from 25px to 28px with your patch installed. But that's OK because without your patch the height isn't enough to display the menubutton correctly either.

As an aside the background colour (some sort of dark grey), in fact the whole styling of the sidebar header is extremely ugly. The background colour doesn't match anything else in the navigator window, in either Classic or Aero mode. In particular it looks totally out of place in Aero. Can something be done?

Comment 3

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/702c3b2337ab