The default bug view has changed. See this FAQ.

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: luke, Unassigned)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 648926 [details] [diff] [review]
rm

IIUC, the result of all this wrapper-purity work in typed arrays is that we don't need this goofy proto-chain walk in getTypedArray:
 - for the js::Class hooks (like obj_getProperty), 'obj' is the typed array (even with wrapped objects, do you know of any exceptions bholley?)
 - for the natives, CallNonGenericMethod does the right thing
 - JSPropertyOp was the remaining case where the given obj is the 'receiver', not the object holding the property, but sfink magnanimously converted them to be accessor properties so the generic accessor mechanism sorts it out

Any other corner cases I'm missing?  Passes jit tests which I believe hold tests for all the issues we've seen in the last few months.  Try'ing now.
Attachment #648926 - Flags: review?(wmccloskey)
Comment on attachment 648926 [details] [diff] [review]
rm

Thanks!
Attachment #648926 - Flags: review?(wmccloskey) → review+
(Reporter)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e9ec6f54266
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/1e9ec6f54266
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Thanks! I meant to file a followup bug to do exactly this, but never got around to it. Probably because I didn't understand the dependency chain, which is a bad excuse.
You need to log in before you can comment on or make changes to this bug.