Closed
Bug 780332
Opened 12 years ago
Closed 12 years ago
rm getTypedArray
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: luke, Unassigned)
Details
Attachments
(1 file)
15.04 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
IIUC, the result of all this wrapper-purity work in typed arrays is that we don't need this goofy proto-chain walk in getTypedArray: - for the js::Class hooks (like obj_getProperty), 'obj' is the typed array (even with wrapped objects, do you know of any exceptions bholley?) - for the natives, CallNonGenericMethod does the right thing - JSPropertyOp was the remaining case where the given obj is the 'receiver', not the object holding the property, but sfink magnanimously converted them to be accessor properties so the generic accessor mechanism sorts it out Any other corner cases I'm missing? Passes jit tests which I believe hold tests for all the issues we've seen in the last few months. Try'ing now.
Attachment #648926 -
Flags: review?(wmccloskey)
Comment on attachment 648926 [details] [diff] [review] rm Thanks!
Attachment #648926 -
Flags: review?(wmccloskey) → review+
Reporter | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e9ec6f54266
Target Milestone: --- → mozilla17
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1e9ec6f54266
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 4•12 years ago
|
||
Thanks! I meant to file a followup bug to do exactly this, but never got around to it. Probably because I didn't understand the dependency chain, which is a bad excuse.
You need to log in
before you can comment on or make changes to this bug.
Description
•