780333 - x86-64 builds fail to call StartAudioSession/StopAudioSession

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Jim Mathies [:jimm]]

http://mxr.mozilla.org/mozilla-central/source/widget/windows/nsAppShell.h#31

http://mxr.mozilla.org/mozilla-central/source/widget/windows/nsAppShell.cpp#159

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 648929 [details] [diff] [review]
patch

This fixes up a missing code path on 64-bit.

Comment 3

[Brian R. Bondy [:bbondy]]

Comment on attachment 648929 [details] [diff] [review]
patch

Nice find

Comment 4

[Frank Wein [:mcsmurf]]

You forgot about this patch? :-) It has not been pushed yet from what I see.

Comment 5

[Frank Wein [:mcsmurf]]

jimm: ping about the patch. Should this patch be checked in?

Comment 6

[Jim Mathies [:jimm]]

Yeah sorry, I'll check to make sure it applies still and land it tomorrow.

Comment 7

[Jim Mathies [:jimm]]

https://tbpl.mozilla.org/?noignore=0&tree=Try&rev=2fdb4b6271b7

Comment 8

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/076d080ee793

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/076d080ee793