Closed
Bug 780387
Opened 12 years ago
Closed 12 years ago
Don't use unnecessary PR* typedefs
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(7 files, 1 obsolete file)
|
2.47 KB,
patch
|
benjamin
:
review+
Ms2ger
:
checkin+
|
Details | Diff | Splinter Review |
|
121.12 KB,
patch
|
benjamin
:
review+
Ms2ger
:
checkin+
|
Details | Diff | Splinter Review |
|
13.40 KB,
patch
|
benjamin
:
review+
Ms2ger
:
checkin+
|
Details | Diff | Splinter Review |
|
15.28 KB,
patch
|
benjamin
:
review+
Ms2ger
:
checkin+
|
Details | Diff | Splinter Review |
|
2.01 KB,
patch
|
benjamin
:
review+
Ms2ger
:
checkin+
|
Details | Diff | Splinter Review |
|
604 bytes,
text/plain
|
Details | |
|
15.24 KB,
patch
|
Details | Diff | Splinter Review |
There is very little point in using, say |typedef size_t PRSize;| when we can use size_t directly.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #648992 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #648993 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #648994 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 4•12 years ago
|
||
Attachment #648995 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 5•12 years ago
|
||
Attachment #648996 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 6•12 years ago
|
||
Turns out those keep sneaking in.
Attachment #648997 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 7•12 years ago
|
||
Parts b-e were generated with a shell script stolen from the prbool bug like this one.
|
||
Updated•12 years ago
|
Attachment #648992 -
Flags: review?(benjamin) → review+
|
|
||
Updated•12 years ago
|
Attachment #648993 -
Flags: review?(benjamin) → review+
|
|
||
Comment 8•12 years ago
|
||
Comment on attachment 648994 [details] [diff] [review] Part c: PRUintn I don't think we should do this for the cases which are using PR_NewThreadPrivateIndex, which still uses PRUintn*.
Attachment #648994 -
Flags: review?(benjamin) → review-
|
|
||
Updated•12 years ago
|
Attachment #648995 -
Flags: review?(benjamin) → review+
|
|
||
Updated•12 years ago
|
Attachment #648996 -
Flags: review?(benjamin) → review+
|
|
||
Updated•12 years ago
|
Attachment #648997 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 9•12 years ago
|
||
I think I caught them all.
Attachment #648994 -
Attachment is obsolete: true
Attachment #650211 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 10•12 years ago
|
||
Comment on attachment 648992 [details] [diff] [review] Part a: PRPtrdiff https://hg.mozilla.org/mozilla-central/rev/62d94d3c6aff
Attachment #648992 -
Flags: checkin+
|
|
Assignee | |
Comment 11•12 years ago
|
||
Comment on attachment 648993 [details] [diff] [review] Part b: PRIntn https://hg.mozilla.org/mozilla-central/rev/4587cc2d0154
Attachment #648993 -
Flags: checkin+
|
|
Assignee | |
Comment 12•12 years ago
|
||
Comment on attachment 648995 [details] [diff] [review] Part d: PRFloat64 https://hg.mozilla.org/mozilla-central/rev/25378953c584
Attachment #648995 -
Flags: checkin+
|
|
Assignee | |
Comment 13•12 years ago
|
||
Comment on attachment 648996 [details] [diff] [review] Part e: PRSize https://hg.mozilla.org/mozilla-central/rev/44fe712a01c8
Attachment #648996 -
Flags: checkin+
|
|
Assignee | |
Comment 14•12 years ago
|
||
Comment on attachment 648997 [details] [diff] [review] Part f: PRBool / PRPackedBool https://hg.mozilla.org/mozilla-central/rev/5b0ac8d41b80
Attachment #648997 -
Flags: checkin+
|
|
||
Comment 15•12 years ago
|
||
Comment on attachment 650211 [details] [diff] [review] Part c: PRUintn (v2) I understand this to have been subsumed by bug 579517, which I hope to get to shortly.
Attachment #650211 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 16•12 years ago
|
||
The parts we're going to fix in this bug are fixed, then.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•