The default bug view has changed. See this FAQ.

Don't use unnecessary PR* typedefs

RESOLVED FIXED in mozilla17

Status

()

Core
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
There is very little point in using, say |typedef size_t PRSize;| when we can use size_t directly.
(Assignee)

Comment 1

5 years ago
Created attachment 648992 [details] [diff] [review]
Part a: PRPtrdiff
Attachment #648992 - Flags: review?(benjamin)
(Assignee)

Comment 2

5 years ago
Created attachment 648993 [details] [diff] [review]
Part b: PRIntn
Attachment #648993 - Flags: review?(benjamin)
(Assignee)

Comment 3

5 years ago
Created attachment 648994 [details] [diff] [review]
Part c: PRUintn
Attachment #648994 - Flags: review?(benjamin)
(Assignee)

Comment 4

5 years ago
Created attachment 648995 [details] [diff] [review]
Part d: PRFloat64
Attachment #648995 - Flags: review?(benjamin)
(Assignee)

Comment 5

5 years ago
Created attachment 648996 [details] [diff] [review]
Part e: PRSize
Attachment #648996 - Flags: review?(benjamin)
(Assignee)

Comment 6

5 years ago
Created attachment 648997 [details] [diff] [review]
Part f: PRBool / PRPackedBool

Turns out those keep sneaking in.
Attachment #648997 - Flags: review?(benjamin)
(Assignee)

Comment 7

5 years ago
Created attachment 648998 [details]
Sample script

Parts b-e were generated with a shell script stolen from the prbool bug like this one.
Attachment #648992 - Flags: review?(benjamin) → review+
Attachment #648993 - Flags: review?(benjamin) → review+
Comment on attachment 648994 [details] [diff] [review]
Part c: PRUintn

I don't think we should do this for the cases which are using PR_NewThreadPrivateIndex, which still uses PRUintn*.
Attachment #648994 - Flags: review?(benjamin) → review-
Attachment #648995 - Flags: review?(benjamin) → review+
Attachment #648996 - Flags: review?(benjamin) → review+
Attachment #648997 - Flags: review?(benjamin) → review+
(Assignee)

Comment 9

5 years ago
Created attachment 650211 [details] [diff] [review]
Part c: PRUintn (v2)

I think I caught them all.
Attachment #648994 - Attachment is obsolete: true
Attachment #650211 - Flags: review?(benjamin)
(Assignee)

Comment 10

5 years ago
Comment on attachment 648992 [details] [diff] [review]
Part a: PRPtrdiff

https://hg.mozilla.org/mozilla-central/rev/62d94d3c6aff
Attachment #648992 - Flags: checkin+
(Assignee)

Comment 11

5 years ago
Comment on attachment 648993 [details] [diff] [review]
Part b: PRIntn

https://hg.mozilla.org/mozilla-central/rev/4587cc2d0154
Attachment #648993 - Flags: checkin+
(Assignee)

Comment 12

5 years ago
Comment on attachment 648995 [details] [diff] [review]
Part d: PRFloat64

https://hg.mozilla.org/mozilla-central/rev/25378953c584
Attachment #648995 - Flags: checkin+
(Assignee)

Comment 13

5 years ago
Comment on attachment 648996 [details] [diff] [review]
Part e: PRSize

https://hg.mozilla.org/mozilla-central/rev/44fe712a01c8
Attachment #648996 - Flags: checkin+
(Assignee)

Comment 14

5 years ago
Comment on attachment 648997 [details] [diff] [review]
Part f: PRBool / PRPackedBool

https://hg.mozilla.org/mozilla-central/rev/5b0ac8d41b80
Attachment #648997 - Flags: checkin+
Comment on attachment 650211 [details] [diff] [review]
Part c: PRUintn (v2)

I understand this to have been subsumed by bug 579517, which I hope to get to shortly.
Attachment #650211 - Flags: review?(benjamin)
(Assignee)

Comment 16

5 years ago
The parts we're going to fix in this bug are fixed, then.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.