Closed Bug 780387 Opened 7 years ago Closed 7 years ago

Don't use unnecessary PR* typedefs

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(7 files, 1 obsolete file)

There is very little point in using, say |typedef size_t PRSize;| when we can use size_t directly.
Attachment #648992 - Flags: review?(benjamin)
Attached patch Part b: PRIntnSplinter Review
Attachment #648993 - Flags: review?(benjamin)
Attached patch Part c: PRUintn (obsolete) — Splinter Review
Attachment #648994 - Flags: review?(benjamin)
Attachment #648995 - Flags: review?(benjamin)
Attached patch Part e: PRSizeSplinter Review
Attachment #648996 - Flags: review?(benjamin)
Turns out those keep sneaking in.
Attachment #648997 - Flags: review?(benjamin)
Attached file Sample script
Parts b-e were generated with a shell script stolen from the prbool bug like this one.
Attachment #648992 - Flags: review?(benjamin) → review+
Attachment #648993 - Flags: review?(benjamin) → review+
Comment on attachment 648994 [details] [diff] [review]
Part c: PRUintn

I don't think we should do this for the cases which are using PR_NewThreadPrivateIndex, which still uses PRUintn*.
Attachment #648994 - Flags: review?(benjamin) → review-
Attachment #648995 - Flags: review?(benjamin) → review+
Attachment #648996 - Flags: review?(benjamin) → review+
Attachment #648997 - Flags: review?(benjamin) → review+
I think I caught them all.
Attachment #648994 - Attachment is obsolete: true
Attachment #650211 - Flags: review?(benjamin)
Comment on attachment 650211 [details] [diff] [review]
Part c: PRUintn (v2)

I understand this to have been subsumed by bug 579517, which I hope to get to shortly.
Attachment #650211 - Flags: review?(benjamin)
The parts we're going to fix in this bug are fixed, then.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.