780404 - Decouple display of today pane in chat tab from mail tab

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Robert Brand]

If you open a chat tab and start a chat conversation there's not much space and so I don't want the today pane here. But disabling it in the chat tab also disables it for the mail tab. One should be able to configure this independent.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Ah yes. I think right now we do it specifically for mail,task,calendar tab. I think this could be extended to work for any tab type by looking at the .type parameter of the tab definition.

I'm happy to mentor someone with this bug, I'd say its a "good second bug" or for skilled developers also a good first bug.

Comment 2

[James Kitchener (:jkitch)]

Not exactly a second bug but this issue annoys me.

I'll have a patch ready in a few days.

Comment 3

[James Kitchener (:jkitch)]

Sorry, I have been distracted by other bugs.  Clearing assign to allow someone else to take it.

Comment 4

[Shubham Jindal [:shubham]]

I am new here and want to contribute to this bug. How should I start?

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Hey Shubham, to get started, please read <https://wiki.mozilla.org/Calendar:Roadmap#Contributing>. Its not a lot of info, but its a good start. I'd suggest setting up the build environment, or if you would just like to try out a few things, just unzip the latest lightning.xpi and set up the extension proxy described here <https://developer.mozilla.org/en-US/Add-ons/Setting_up_extension_development_environment#Firefox_extension_proxy_file>

The latest Lightning is available from the nightly locations and are linked in the development snapshots section of this document <https://developer.mozilla.org/en-US/docs/Mozilla/Calendar/Calendar_Versions>.

You can search the code using <http://mxr.mozilla.org/comm-central/>. For the today pane we use a binding that was written a long time ago called a modebox, its code is here: http://mxr.mozilla.org/comm-central/source/calendar/base/content/widgets/calendar-widgets.xml#290

The goal would be to determine if the modebox can either be extended to take the "chat" mode into account, or see if its worth not using the binding at all for the today pane.

Let me know if you have questions, you can also reach me on IRC. My nickname is Fallen.

Comment 6

[Paul Morris [:pmorris]]

Assigning this to myself since it is closely related to the work I'm doing for bug 1583529.

Comment 7

[Paul Morris [:pmorris]]

Attachment: separate-mail-and-chat-todaypane-0.patch

This depends on the patches in bug 1583529.

Try server run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0926c1e102ea48cb424f360302d98b4aea353863

Comment 8

[Paul Morris [:pmorris]]

Attachment: separate-mail-and-chat-today-pane-1.patch

Rebased and reworked on top of changes in patches in bug 1583529.

Comment 9

[Geoff Lankow (:darktrojan)]

Comment on attachment 9098620 [details] [diff] [review]
separate-mail-and-chat-today-pane-1.patch

Review of attachment 9098620 [details] [diff] [review]:
-----------------------------------------------------------------

R+ with similar changes to the test that I just requested in the other bug.

::: calendar/lightning/content/messenger-overlay-sidebar.js
@@ +658,5 @@
>   *
>   * @param {string} mode  The mode to switch to.
>   */
>  function calSwitchToMode(mode) {
> +  if (mode != "mail" && mode != "chat" && mode != "special") {

["mail", "chat", "special"].includes(mode) looks tidier.

Comment 10

[Paul Morris [:pmorris]]

Attachment: separate-mail-and-chat-today-pane-2.patch

Thanks for the review. This makes those changes.

Here's a try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=bb20a08bf5fd707d23539ea45e4747da4c93c71a&selectedJob=269779740

The try run has an eslint error that has already been fixed in this patch.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b1d22780fc37
Make today pane in chat and mail tabs independent. r=darktrojan