Last Comment Bug 780414 - Build failing with ../config/ ../src/config/ No such file or directory
: Build failing with ../config/ ../src/config/ No...
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- blocker (vote)
: mozilla17
Assigned To: Mike Hommey [:glandium]
: Gregory Szorc [:gps]
Depends on:
Blocks: 774032
  Show dependency treegraph
Reported: 2012-08-04 13:05 PDT by Justin Lebar (not reading bugmail)
Modified: 2012-08-05 21:08 PDT (History)
8 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Make top_srcdir absolute in config.status (1.35 KB, patch)
2012-08-04 14:56 PDT, Mike Hommey [:glandium]
no flags Details | Diff | Splinter Review
Fix for the case where top_srcdir is a path relative to topobjdir. (20.91 KB, patch)
2012-08-05 00:06 PDT, Mike Hommey [:glandium]
khuey: review+
Details | Diff | Splinter Review

Description Justin Lebar (not reading bugmail) 2012-08-04 13:05:45 PDT
Linux x64 clobber build, tip of m-c (0a17cde2a4b6) is failing for me during configure:

make[5]: Entering directory `/home/jlebar/code/moz/ff-git/debug/config'
../config/ ../src/config/ No such file or directory
Makefile:53: ../src/config/ No such file or directory
Makefile:58: ../src/config/ No such file or directory
make[5]: *** No rule to make target `../src/config/'.  Stop.
Comment 1 Siddharth Agarwal [:sid0] (inactive) 2012-08-04 13:22:12 PDT
Likely due to bug 774032.
Comment 2 Mike Hommey [:glandium] 2012-08-04 14:39:20 PDT
How is your mozconfig?
Comment 3 Mike Hommey [:glandium] 2012-08-04 14:56:01 PDT
Created attachment 649034 [details] [diff] [review]
Make top_srcdir absolute in config.status

This should work as a workaround, provided that pwd returns a msys path on windows.

I however would like to fix this more nicely.
Comment 4 Siddharth Agarwal [:sid0] (inactive) 2012-08-04 15:33:24 PDT
Don't rely on pwd to return an msys path on Windows. See bug 777798.
Comment 5 Justin Lebar (not reading bugmail) 2012-08-04 15:47:11 PDT
(In reply to Mike Hommey [:glandium] from comment #2)
> How is your mozconfig?

. $topsrcdir/browser/config/mozconfig

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../debug
ac_add_options --srcdir=../src

ac_add_options --enable-trace-malloc
ac_add_options --enable-debug
ac_add_options --disable-optimize
ac_add_options --with-ccache

mk_add_options MOZ_MAKE_FLAGS="-j16"
ac_add_options --enable-application=browser
Comment 6 Justin Lebar (not reading bugmail) 2012-08-04 15:48:35 PDT
Oh, I see how that srcdir is getting in there now.

Maybe I don't need srcdir anymore; it was to make ccache happier caching object files between checkouts, but perhaps our build or ccache has become smarter since then.
Comment 7 Justin Lebar (not reading bugmail) 2012-08-04 21:40:04 PDT
As expected, removing the explicit srcdir fixes the problem for me.  I'm still not sure if it's doing anything good for me.
Comment 8 Mike Hommey [:glandium] 2012-08-04 23:19:41 PDT
FWIW, this happens if you either build with a relative --srcdir like you did, or just run configure directly, from a relative directory.
Comment 9 Mike Hommey [:glandium] 2012-08-05 00:04:53 PDT
Considering this doesn't affect building with make -f under "normal" circumstances, I'll leave bug 774032 in. Actual fix coming next.
Comment 10 Mike Hommey [:glandium] 2012-08-05 00:06:21 PDT
Created attachment 649078 [details] [diff] [review]
Fix for the case where top_srcdir is a path relative to topobjdir.

It turns out the unittest was completely wrong for testing srcdir, so this bug came through while it shouldn't have :-/
Comment 12 Ryan VanderMeulen [:RyanVM] 2012-08-05 17:40:26 PDT
Comment 13 Axel Hecht [:Pike] 2012-08-05 18:24:07 PDT
I hope that this may fix the l10n repacks, too, need to see in the next nightlies.
Comment 14 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-08-05 21:08:23 PDT
I pushed a followup to unbreak pymake (and hopefully not rebreak anything else).

Note You need to log in before you can comment on or make changes to this bug.