Closed
Bug 780462
Opened 13 years ago
Closed 12 years ago
Stop removing dist/bin/components when starting a build
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla19
People
(Reporter: glandium, Assigned: glandium)
Details
(Whiteboard: [buildfaster:?])
Attachments
(1 file, 2 obsolete files)
As said in http://gregoryszorc.com/blog/2012/07/29/mozilla-central-build-times/ comments by Neil Rashbrook, we've had manifests for two years.
However, as a consequence, we should remove the top chrome.manifest, because otherwise components that are removed from the tree but still in dist/bin/components because they were not rm -rfed at the beginning of the build, would still be registered.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #649092 -
Flags: review?(khuey)
Assignee | ||
Updated•13 years ago
|
Whiteboard: [buildfaster:?]
Comment on attachment 649092 [details] [diff] [review]
Don't remove dist/bin/components when building, but remove dist/bin/chrome.manifest
Review of attachment 649092 [details] [diff] [review]:
-----------------------------------------------------------------
Mildly scary, but ok.
Attachment #649092 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Target Milestone: --- → mozilla17
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•12 years ago
|
||
D'oh. The patch was wrong.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•12 years ago
|
||
Oops. Didn't quite do what it was intended to do.
Attachment #670283 -
Flags: review?(khuey)
Assignee | ||
Updated•12 years ago
|
Attachment #649092 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Attachment #670283 -
Attachment is obsolete: true
Attachment #670283 -
Flags: review?(khuey)
Attachment #670332 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 8•12 years ago
|
||
Comment 9•12 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 13 years ago → 12 years ago
Resolution: --- → FIXED
Target Milestone: mozilla17 → mozilla19
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•