The default bug view has changed. See this FAQ.

Stop removing dist/bin/components when starting a build

RESOLVED FIXED in mozilla19

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla19
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [buildfaster:?])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
As said in http://gregoryszorc.com/blog/2012/07/29/mozilla-central-build-times/ comments by Neil Rashbrook, we've had manifests for two years.

However, as a consequence, we should remove the top chrome.manifest, because otherwise components that are removed from the tree but still in dist/bin/components because they were not rm -rfed at the beginning of the build, would still be registered.
(Assignee)

Comment 1

5 years ago
Created attachment 649092 [details] [diff] [review]
Don't remove dist/bin/components when building, but remove dist/bin/chrome.manifest
Attachment #649092 - Flags: review?(khuey)
(Assignee)

Updated

5 years ago
Whiteboard: [buildfaster:?]
Comment on attachment 649092 [details] [diff] [review]
Don't remove dist/bin/components when building, but remove dist/bin/chrome.manifest

Review of attachment 649092 [details] [diff] [review]:
-----------------------------------------------------------------

Mildly scary, but ok.
Attachment #649092 - Flags: review?(khuey) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/fda1cd4d7dba
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/fda1cd4d7dba
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

5 years ago
D'oh. The patch was wrong.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

5 years ago
Created attachment 670283 [details] [diff] [review]
Actually remove dist/bin/chrome.manifest when starting a new build

Oops. Didn't quite do what it was intended to do.
Attachment #670283 - Flags: review?(khuey)
(Assignee)

Updated

5 years ago
Attachment #649092 - Attachment is obsolete: true
(Assignee)

Comment 7

5 years ago
Created attachment 670332 [details] [diff] [review]
Actually remove dist/bin/chrome.manifest when starting a new build, and also remove dist/bin/components/components.manifest

While at it...
Attachment #670332 - Flags: review?(khuey)
(Assignee)

Updated

5 years ago
Attachment #670283 - Attachment is obsolete: true
Attachment #670283 - Flags: review?(khuey)
Attachment #670332 - Flags: review?(khuey) → review+
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ca0df7f08fc
https://hg.mozilla.org/mozilla-central/rev/9ca0df7f08fc
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: mozilla17 → mozilla19
You need to log in before you can comment on or make changes to this bug.