Closed Bug 780462 Opened 12 years ago Closed 12 years ago

Stop removing dist/bin/components when starting a build

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla19

People

(Reporter: glandium, Assigned: glandium)

Details

(Whiteboard: [buildfaster:?])

Attachments

(1 file, 2 obsolete files)

As said in http://gregoryszorc.com/blog/2012/07/29/mozilla-central-build-times/ comments by Neil Rashbrook, we've had manifests for two years.

However, as a consequence, we should remove the top chrome.manifest, because otherwise components that are removed from the tree but still in dist/bin/components because they were not rm -rfed at the beginning of the build, would still be registered.
Whiteboard: [buildfaster:?]
Comment on attachment 649092 [details] [diff] [review]
Don't remove dist/bin/components when building, but remove dist/bin/chrome.manifest

Review of attachment 649092 [details] [diff] [review]:
-----------------------------------------------------------------

Mildly scary, but ok.
Attachment #649092 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/fda1cd4d7dba
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
D'oh. The patch was wrong.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Oops. Didn't quite do what it was intended to do.
Attachment #670283 - Flags: review?(khuey)
Attachment #649092 - Attachment is obsolete: true
Attachment #670283 - Attachment is obsolete: true
Attachment #670283 - Flags: review?(khuey)
https://hg.mozilla.org/mozilla-central/rev/9ca0df7f08fc
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Target Milestone: mozilla17 → mozilla19
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.