Last Comment Bug 780508 - Pymake: avoid spawning shell processes while compiling
: Pymake: avoid spawning shell processes while compiling
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla17
Assigned To: Siddharth Agarwal [:sid0] (inactive)
:
: Gregory Szorc [:gps]
Mentors:
: 602494 (view as bug list)
Depends on:
Blocks: 602492 585011
  Show dependency treegraph
 
Reported: 2012-08-05 14:00 PDT by Siddharth Agarwal [:sid0] (inactive)
Modified: 2012-08-09 08:59 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v1 (2.32 KB, patch)
2012-08-05 14:00 PDT, Siddharth Agarwal [:sid0] (inactive)
khuey: review+
Details | Diff | Splinter Review
patch to comm-central v1 (1.21 KB, patch)
2012-08-05 14:07 PDT, Siddharth Agarwal [:sid0] (inactive)
khuey: review+
Details | Diff | Splinter Review

Description Siddharth Agarwal [:sid0] (inactive) 2012-08-05 14:00:46 PDT
Created attachment 649131 [details] [diff] [review]
patch v1

Two improvements:
1. In silent mode, we hook in an ELOG because GNU make doesn't print the command that failed. Pymake does, so the hook just creates unnecessary shell processes.
2. REPORT_BUILD causes a shell invocation for every single file build, and it can simply be replaced with $(info) since it's always the first command in a recipe.
Comment 1 Siddharth Agarwal [:sid0] (inactive) 2012-08-05 14:02:04 PDT
This seems to speed up builds by around 2 minutes (4-5%) on my computer.
Comment 2 Siddharth Agarwal [:sid0] (inactive) 2012-08-05 14:07:04 PDT
Created attachment 649132 [details] [diff] [review]
patch to comm-central v1
Comment 3 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-08-06 08:01:35 PDT
Comment on attachment 649131 [details] [diff] [review]
patch v1

Review of attachment 649131 [details] [diff] [review]:
-----------------------------------------------------------------

Haha, nice.
Comment 4 Siddharth Agarwal [:sid0] (inactive) 2012-08-06 09:17:26 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/5804800a7009

I still need to check in the comm-central patch.
Comment 5 Ziga Seilnacht 2012-08-06 11:38:01 PDT
Bug 602494 seems to be a duplicate of this bug.
Comment 6 Siddharth Agarwal [:sid0] (inactive) 2012-08-06 13:58:33 PDT
*** Bug 602494 has been marked as a duplicate of this bug. ***
Comment 7 Siddharth Agarwal [:sid0] (inactive) 2012-08-06 13:59:06 PDT
Thanks Ziga, didn't know about it.
Comment 8 Ryan VanderMeulen [:RyanVM] 2012-08-06 17:10:56 PDT
https://hg.mozilla.org/mozilla-central/rev/5804800a7009
Comment 9 Siddharth Agarwal [:sid0] (inactive) 2012-08-07 12:14:29 PDT
http://hg.mozilla.org/comm-central/rev/914c29a1a1e3

Note You need to log in before you can comment on or make changes to this bug.