780508 - Pymake: avoid spawning shell processes while compiling

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch v1

Two improvements:
1. In silent mode, we hook in an ELOG because GNU make doesn't print the command that failed. Pymake does, so the hook just creates unnecessary shell processes.
2. REPORT_BUILD causes a shell invocation for every single file build, and it can simply be replaced with $(info) since it's always the first command in a recipe.

Comment 1

[Rain [:rain1] (inactive)]

This seems to speed up builds by around 2 minutes (4-5%) on my computer.

Comment 2

[Rain [:rain1] (inactive)]

Attachment: patch to comm-central v1

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 649131 [details] [diff] [review]
patch v1

Review of attachment 649131 [details] [diff] [review]:
-----------------------------------------------------------------

Haha, nice.

Comment 4

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5804800a7009

I still need to check in the comm-central patch.

Comment 5

[Ziga Seilnacht]

Bug 602494 seems to be a duplicate of this bug.

Comment 7

[Rain [:rain1] (inactive)]

Thanks Ziga, didn't know about it.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5804800a7009

Comment 9

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/comm-central/rev/914c29a1a1e3