780510 - Incorrect display of table row when changing contents dynamically

Status: RESOLVED WORKSFORME

(Core :: Layout: Tables, defect)

Description

[Sebastian Zartner [:sebo]]

Attachment: Test case

When changing the contents of a table cell dynamically it can happen that the height of the row is not adjusted correctly.

See the attached test case for an example. To see the bug click two times at "click here!!".

This problem was found while investigating the following Firebug issue:

http://code.google.com/p/fbug/issues/detail?id=5769

Sebastian

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

Last good nightly: 2011-09-29
First bad nightly: 2011-09-30

Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e7854b4d29ba&tochange=10298b25af4e

Comment 2

[(mostly gone) XtC4UaLL [:xtc4uall]]

by Bug 10209/Bug 659828?

Comment 3

[Alice0775 White]

Last Good: 34f184d2a6f8 Ehsan Akhgari — Bug 10209 - Part 5: Allow table elements to act as absolute positioning containers; r=roc
First bad: 00f422b2cf36 Ehsan Akhgari — Bug 10209 - Part 6: Implement the CSS "containing block" concept correctly as a binary relation, as opposed to a unary relation; r=bzbarsky

Comment 4

[Boris Zbarsky [:bzbarsky]]

Ehsan, do you have time to look into this?

Comment 5

[(no longer active)]

(In reply to Boris Zbarsky (:bz) [In and out Aug 1 - 10, out Aug 11-20] from comment #4)
> Ehsan, do you have time to look into this?

Not really.  :(  Do we have someone else who can look into this?

Comment 6

[Sebastian Zartner [:sebo]]

(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #5)
> (In reply to Boris Zbarsky (:bz) [In and out Aug 1 - 10, out Aug 11-20] from
> comment #4)
> > Ehsan, do you have time to look into this?
> 
> Not really.  :(  Do we have someone else who can look into this?

Two years later still no time? If not, could we find someone to look into this?

Sebastian

Comment 7

[(no longer active)]

(In reply to Sebastian Zartner [:sebo] from comment #6)
> (In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from
> comment #5)
> > (In reply to Boris Zbarsky (:bz) [In and out Aug 1 - 10, out Aug 11-20] from
> > comment #4)
> > > Ehsan, do you have time to look into this?
> > 
> > Not really.  :(  Do we have someone else who can look into this?
> 
> Two years later still no time? If not, could we find someone to look into
> this?

Oh, this totally slipped through the cracks, my apologies. :(

I tried to debug and see what's going on, but all of the intricacies of the table layout code have escaped me since I last looked at it...  David, do you know who's the closest person to this code these days?  The regressing changeset is unfortunateky a very big change, that has cost similar regressions such as bug 729143.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Probably dholbert or me.  Seth has looked at it a little, but stepped away from it.

Comment 9

[Sebastian Zartner [:sebo]]

(In reply to David Baron [:dbaron] (UTC-8) (needinfo? for questions) from comment #8)
> Probably dholbert or me.  Seth has looked at it a little, but stepped away
> from it.

So I added you both to the CC list, so this issue is not forgotten again. Hope that's ok for you.

Sebastian

Comment 10

[(no longer active)]

Dan, can you take a look, please?  Thanks!

Comment 11

[Daniel Holbert [:dholbert]]

I can try, but I don't know how soon I'll get to it. (I've got some other high-priority-ish items ahead of this in my to-do list.)

Comment 12

[Sebastian Zartner [:sebo]]

Just tested this again in Firefox 62.0 and cannot reproduce the issue anymore. The height of the table row correctly gets resized when the table cell contents are changed. So, I'm finally closing this.

Sebastian