Last Comment Bug 780554 - Mozmill test failure testSearch/testAddMozSearchProvider | Current URL contains the wrong search term
: Mozmill test failure testSearch/testAddMozSearchProvider | Current URL contai...
Product: Mozilla QA
Classification: Other
Component: Mozmill Tests (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Maniac Vlad Florin (:vladmaniac)
Depends on:
Blocks: 780619
  Show dependency treegraph
Reported: 2012-08-05 22:54 PDT by Maniac Vlad Florin (:vladmaniac)
Modified: 2012-08-06 08:27 PDT (History)
2 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

quickey v1.0 (1.25 KB, patch)
2012-08-05 23:25 PDT, Maniac Vlad Florin (:vladmaniac)
dave.hunt: review-
Details | Diff | Splinter Review
fix patch 2.0 (1.86 KB, patch)
2012-08-06 01:34 PDT, Maniac Vlad Florin (:vladmaniac)
hskupin: review-
Details | Diff | Splinter Review
patch v2.1 (2.84 KB, patch)
2012-08-06 02:04 PDT, Maniac Vlad Florin (:vladmaniac)
hskupin: review-
Details | Diff | Splinter Review
patch v2.2 (2.83 KB, patch)
2012-08-06 06:10 PDT, Maniac Vlad Florin (:vladmaniac)
hskupin: review+
Details | Diff | Splinter Review

Description Maniac Vlad Florin (:vladmaniac) 2012-08-05 22:54:16 PDT
This is failing constantly on all platforms since MDN change lately and this test uses a search engine which points to a MDN search

Local error log: 
"message": "Current URL contains the search term - got '', expected 'firefox'"
matches mozmill-ci report:

Mozmill version: 1.5.17
Platforms: all
Comment 1 Maniac Vlad Florin (:vladmaniac) 2012-08-05 23:25:37 PDT
Created attachment 649192 [details] [diff] [review]
quickey v1.0

So this is a simple fix - 
* just changed the search term because there were no search results in the new MDN for "Firefox" string.
* also, in the long term, I would suggest switching MDN with a mozqa page - not a local search engine (because this is the only test remaining to use the modal dialog and thoroughly test the UI and IMO we need it). MDN points to a browser ID login at the moment and I don't think we want to use credentials in our tests (I mean we did not so far)
Comment 2 Maniac Vlad Florin (:vladmaniac) 2012-08-05 23:44:13 PDT
The patch will apply cleanly also on mozilla-esr10 branch
Comment 3 Dave Hunt (:davehunt) 2012-08-06 01:19:45 PDT
Comment on attachment 649192 [details] [diff] [review]
quickey v1.0

>-{text: "Firefox", action: "goButton"});
>+{text: "Mozilla", action: "goButton"});

This is not a valid change. The string 'mozilla' appears in the URL because of the domain name, not because the search term has been passed correctly. This makes the test a false positive as the search functionality is not being tested at all.

We should change this test to use a local page, or at least to use
Comment 4 Maniac Vlad Florin (:vladmaniac) 2012-08-06 01:34:00 PDT
Created attachment 649217 [details] [diff] [review]
fix patch 2.0

Fixed to use a page from 
Thanks Dave for the fast review
Comment 5 Henrik Skupin (:whimboo) 2012-08-06 01:43:43 PDT
Comment on attachment 649217 [details] [diff] [review]
fix patch 2.0

If we are going to use we have to update the whole XML file. Just replacing the Url entry is not all as you can see when closely watching the file.

Also, I still want to see this test using a local search provider, but that's clearly a different bug.
Comment 6 Maniac Vlad Florin (:vladmaniac) 2012-08-06 02:04:37 PDT
Created attachment 649220 [details] [diff] [review]
patch v2.1

You're right, sorry for missing the rest of the details.
Comment 7 Henrik Skupin (:whimboo) 2012-08-06 05:58:37 PDT
Comment on attachment 649220 [details] [diff] [review]
patch v2.1

>+  <ShortName>Moz Search</ShortName>

Please use '' as short name.

>+  <Description>Mozilla QA Search Results Page</Description>

Same here: ' search results'
Comment 8 Maniac Vlad Florin (:vladmaniac) 2012-08-06 06:10:15 PDT
Created attachment 649248 [details] [diff] [review]
patch v2.2

Comment 9 Henrik Skupin (:whimboo) 2012-08-06 07:24:59 PDT
Comment on attachment 649248 [details] [diff] [review]
patch v2.2

I will land it across branches now. Vlad, please file an infrastructure bug so we can get the XML file updated in the litmus-data repository.

Note You need to log in before you can comment on or make changes to this bug.