The default bug view has changed. See this FAQ.

Text gets selected just by hovering the mouse over

RESOLVED FIXED in Firefox 16

Status

()

Core
Selection
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: simonab, Assigned: roc)

Tracking

({regression, reproducible})

unspecified
mozilla17
x86
Windows 7
regression, reproducible
Points:
---

Firefox Tracking Flags

(firefox15+ wontfix, firefox16+ verified, firefox17+ verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0

While verifying Bug 761572 I stumbled upon this issue.

Reproducible: always

Steps to reproduce:
1. Navigate to https://bug761572.bugzilla.mozilla.org/attachment.cgi?id=630142
2. Click on the 'Set display to none' button
3. Move the mouse over the text without clicking on anything.

Expected results:
The background text doesn't get selected. 

Actual results:
The background text gets selected. After hitting the OK button from the prompt displayed in step 2 the issue doesn't reproduce.
Component: Event Handling → Selection

Comment 1

5 years ago
#1  Alert box does not  pop up
#2  Fixed #1, but selection problem happens 

#1 Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/f6d082275253
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120530012752
Bad(Alert box does not  pop up):
http://hg.mozilla.org/mozilla-central/rev/b5af439f1717
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120530042453
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f6d082275253&tochange=b5af439f1717

#1 Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/cfd001299d34
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120529021158
Bad(Alert box does not  pop up):
http://hg.mozilla.org/integration/mozilla-inbound/rev/d0beb7e43cc4
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120529061423
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=cfd001299d34&tochange=d0beb7e43cc4
#1 Suspected: Bug 758179


#2 Regression window(m-c)
Bad(Alert box does not  pop up):
http://hg.mozilla.org/mozilla-central/rev/5891cc95eac7
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0a1 ID:20120607140205
Bad(Fixed #1, but selection problem happens ):
http://hg.mozilla.org/mozilla-central/rev/22bb7d46bb23
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0a1 ID:20120608081921
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5891cc95eac7&tochange=22bb7d46bb23


#2 Regression window(m-i)
Bad(Alert box does not  pop up):
http://hg.mozilla.org/integration/mozilla-inbound/rev/5a1dc5b1ecbb
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0a1 ID:20120607014319
Bad(Fixed #1, but selection problem happens ):
http://hg.mozilla.org/integration/mozilla-inbound/rev/4f28fd1e2d81
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0a1 ID:20120607030819
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5a1dc5b1ecbb&tochange=4f28fd1e2d81
#2 Suspected: Bug 761572
Blocks: 761572
Keywords: regression

Updated

5 years ago
tracking-firefox15: --- → ?
tracking-firefox16: --- → ?
tracking-firefox17: --- → ?
Assigning to roc to take a look, since bug 761572 is being fingered as the potential culprit here, tracking as well for being a 15 regression, would be great to never ship this.
Assignee: nobody → roc
status-firefox15: --- → affected
status-firefox16: --- → affected
status-firefox17: --- → affected
tracking-firefox15: ? → +
tracking-firefox16: ? → +
tracking-firefox17: ? → +
Keywords: reproducible
I'll work on this, but I don't think we should worry about it for FF15. It's a minor bug that only happens in situations where we were completely broken before (i.e. in the testcase, the alert box not popping up).
Created attachment 649543 [details] [diff] [review]
fix

This fixes it.

I haven't been able to find a good way to test this. For some reason the alert() is needed; without it, nsFrame::HandleRelease isn't called, but somehow mouse movement stops selecting anyway.
Attachment #649543 - Flags: review?(bugs)
Attachment #649543 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d75263064dc5
https://hg.mozilla.org/mozilla-central/rev/d75263064dc5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17

Updated

5 years ago
status-firefox17: affected → fixed
Comment on attachment 649543 [details] [diff] [review]
fix

Review of attachment 649543 [details] [diff] [review]:
-----------------------------------------------------------------

So far so good. I think this is plenty safe enough for Aurora.
Attachment #649543 - Flags: approval-mozilla-aurora?
Attachment #649543 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
This was a regression in 15 and even if the instances of it occurring are rare-ish, it's still nice to never ship something like this that users will run up against and be frustrated by - do you think this is low-risk enough to take before our next Beta?
(In reply to Lukas Blakk [:lsblakk] from comment #8)
> This was a regression in 15 and even if the instances of it occurring are
> rare-ish, it's still nice to never ship something like this that users will
> run up against and be frustrated by - do you think this is low-risk enough
> to take before our next Beta?

Just got info from roc in email and I agree with him that this bug is not important enough to take so late in Beta, see comment 3 as well.
This still needs to land on Aurora, wontfixing for FF15.
status-firefox15: affected → wontfix
Keywords: checkin-needed
https://hg.mozilla.org/releases/mozilla-aurora/rev/65ac00871b6e
status-firefox16: affected → fixed
Keywords: checkin-needed
Keywords: verifyme
(Reporter)

Comment 12

5 years ago
Verified on Firefox 16 beta 4 that the text does not get selected anymore when hovering the mouse over (used the test case from the Description).
Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20100101 Firefox/16.0
Build ID: 20120919065210
status-firefox16: fixed → verified
QA Contact: simona.marcu
(Reporter)

Comment 13

5 years ago
Verified as fixed on Firefox 17 beta 1 - the text does not get selected when hovering the mouse over.
Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/17.0 Firefox/17.0
status-firefox17: fixed → verified
mass remove verifyme requests greater than 4 months old
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.