78060 - no keyboard (menu) access to insert-smiley feature

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Jesse Ruderman]

Most of the toolbar buttons in message compose have menu equivalents, but the 
insert-smiley feature doesn't.  This means there's no way to insert a graphical 
smiley using the keyboard :(

(Filing against Editor instead of Message Composition because I think this 
feature is also used in IM, and because bug 66213 is in the Editor component.)

Comment 1

[kinmoz]

This should go to [e-mail].

Comment 2

[Anatoliy Averbukh]

Attachment: added smiley to editor

Comment 3

[Anatoliy Averbukh]

Please r/sr.

Comment 4

[kinmoz]

Anatoliy, this bug isn't requesting that smileys be added to Composer. I think 
it was already decided that we shouldn't be adding smileys to Composer.

This bug is about the fact that most of the items on MsgCompose's toolbar are 
also under the main menus ... smileys are only available via the toolbar. The 
user is also requesting that keyboard shortcuts for the various smileys be 
added.

Comment 5

[Kathleen :Brade]

Anatoliy does not yet need r= or sr=.  He is working on a new fix which will add 
accessibility but not add the smiley feature to Composer.

This is really an accessibility bug and should be in Keyboard Navigation (not 
Editor).

Jesse--are you suggesting that the insert smiley menu should be a hierarchical 
menu below the insert menu?

Comment 6

[Charles Manske]

No! We don't wan't the "Smiley" button on the toolbar.
Adding it as a submenu under "Insert" is acceptable.

Comment 7

[Jesse Ruderman]

Yes, there should be a submenu or menu item for inserting smilies in the Insert 
menu of the Message Compose window.  This shouldn't be necessary in a normal 
Composer window, since smilies are only supported in messages anyway.

Would using a submenu (as opposed to a menu item that brings up a dialog) only 
allow the text descriptions of the smilies to be shown, or do Mozilla's menus 
support large icons?

Comment 8

[Aaron Leventhal]

Keyboard access to all features is a requirement for Mozilla-based products to
be sold to the goverment.

Comment 9

[timeless]

does the reg require that people be able to trigger things the same exact way?

if users can insert smilies using the keyboard i don't quite understand why we 
need to let them activate a dropdown widget (although i wouldn't oppse support 
for tabbing through toolbars).

Comment 10

[Aaron Leventhal]

Well, it's a feature that you can choose the smiley based on a named emotion.
That feature is not available.

I suppose it could slide on the technicality though.

Comment 11

[rubydoo123]

removing myself from the cc list

Comment 12

[[e-mail]]

Attachment: Add Smiley face menu after Insert/HTML in HTML message compose

Comment 13

[Ben Bucksch (:BenB)]

Is there any Mozilla app which sends/saves these *graphical* smilies? If not, we
have an easy and intuitive keyboard access: Type ":-)".

Even if some Mozilla app sends graphical smilies (Mailnews surely does not), I
don't think that anybody limited to keyboard is keen on using them. Text-only
smilies are so commonplace and so much faster and more convient to type that I
don't think that anybody used to the keyboard will bother about graphical smilies.

In fact, I think don't understand why we have these graphical smilies at all.
Anyways, adding a submenu just so we can add key accelerators sounds quite silly
to me. As if we didn't have enough menus already.

As for government requirements, I'd argue that text-only smilies do it, for the
above reason.

Comment 14

[Kathleen :Brade]

Aaron--would you prefer Neil's patch or Ben's argument?  If you prefer Ben's
argument, we should resolve this bug as wontfix.

Comment 15

[Aaron Leventhal]

I think Ben's argument makes sense, except in IM (I know, this is not in
Mozilla). In IM we already have the menu, which contains a list of emotions that
you can pick from. In other words, if there is already a menu available for
mouse users, it should also be available from the keyboard. If there is not, we
can leave it alone.

On the other hand, can anyone name off the different ascii equivalents for the
different emotions we support? Are they actually listed anywhere?

Comment 16

[timeless]

aim 4.8.2646
:-) =-O :-$ :-\
:-( :-* :-! :'(
;-) >:o :-[ :-X
:-P 8-) O:-) :-D
procedure: load aim, click each smily, copy to nc4
as for giving friendly names ... um

the following is subject to analysis or negotation
) smile
( frown
; wink
P thpbbt
= startled
* smoking
> shocked
8 cool
$ scared
! surprised
[ toungue biting
0 angelic
\ disappointed
' crying
X silenced
D happy toungue

Comment 17

[Anatoliy Averbukh]

For IM or email it isn't suitable. Because it must be compatible with another 
IM clients (they are not Netscape or Mozilla).
So, we need to support 3-char sequences.

Comment 18

[ArronM (:paper)]

I've found that :-D is typically "Yay" and ":-/" is typically "worried"

In some communities, :-X or :-* is kiss, in others it's silence & smoking as
mentioned.

Comment 19

[timeless]

comment 17 is cryptic. what in the world was it in reference to?

my single character prefixes where for accesskeys for a menu which had the 
smilies listed previously.

Comment 20

[Jesse Ruderman]

For Instant Messenger: http://bugscape.netscape.com/show_bug.cgi?id=11804,
"Can't access smiley menu via keyboard (Menus or shortcuts)".

Comment 21

[Stephen Walker]

*** Bug 155104 has been marked as a duplicate of this bug. ***

Comment 22

[varada]

Re-assigning bug to varada

Comment 23

[varada]

Attachment: Editor part of patch

Importing patch from 155104

Comment 24

[varada]

Attachment: MailCompose portion of patch

Mailcompose portion of patch

Comment 25

[Jean-Francois Ducarroz]

Comment on attachment 91878 [details] [diff] [review]
Editor part of patch

R=ducarroz

Comment 26

[Jean-Francois Ducarroz]

Comment on attachment 91879 [details] [diff] [review]
MailCompose portion of patch

missing the diff for the jar file (and maybe the .in file to) Appart that,
R=ducarroz

Comment 27

[varada]

Attachment: changes to jar.mn

Changes to jar and there is no Makefile.in there.

Comment 28

[Jean-Francois Ducarroz]

Comment on attachment 91881 [details] [diff] [review]
changes to jar.mn

R=ducarroz

Comment 29

[[e-mail]]

Comment on attachment 91879 [details] [diff] [review]
MailCompose portion of patch

Where are your entities?
I don't see insertSmiley.label defined anywhere. Also while the
smileyNCmd.label entities have definitions in editorOverlay.dtd you are trying
to use messengercompose.dtd which does not define them.

Comment 30

[varada]

Attachment: Changes to dtd files

Localization Changes for smiley menu items.

Comment 31

[David :Bienvenu]

has anyone one the UE team looked at the new strings? cc'ing Jennifer.

Comment 32

[varada]

Moving comments from DUP bug #155104.
------- Additional Comment #2 From [e-mail] 2002-07-01 10:27 -------

Add "_S_miley" to the Insert Menu below "Characters and Symbols".

Flyout smiley menu:
_S_mile
_F_rown
_W_ink
_T_ongue-out
_L_aughing
_E_mbarrassed
_U_ndecided

Comment 33

[jglick]

>Additional Comment #30 From [e-mail] 2002-07-19 09:44
>Created an attachment (id=91962)
>Changes to dtd files

Looks good.
Only comment, are you adding the tooltip:
+<!ENTITY SmileButton.tooltip "Choose smiley face">
If so, can it say "Insert a smiley face" instead?

Comment 34

[varada]

Attachment: Changes to dtd files v1.1

Changed the tooltip wording as per Jennifer's suggestions.

Comment 35

[David :Bienvenu]

Comment on attachment 95653 [details] [diff] [review]
Changes to dtd files v1.1

sr=bienvenu

Comment 36

[varada]

Marking Fixed.

Comment 37

[Grace Bush]

verified 

Comment 38

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381