780631 - Don't change the selected script while filtering if the file part from the search expression hasn't changed

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

If there are two very similarly named files, for example:

foo/bar/baz.js
baz.js

...then when trying a filter like baz.js#token, for each letter entered in the #token, the selected script switches to `foo/bar/todos.js` if the previously selected script was `todos.js`.

Thus, the script always switches to the first found mach. This annoyed me today.

Comment 1

[Victor Porof [:vporof][:vp]]

s/todos/baz :)

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 650180 [details] [diff] [review]
v1

-    if (token.length) {
+    if (this._prevSearchedToken !== token && token.length > 0) {

could just use && token.length but OK for highlighting you have a number there.

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #3)
> Comment on attachment 650180 [details] [diff] [review]
> v1
> 
> -    if (token.length) {
> +    if (this._prevSearchedToken !== token && token.length > 0) {
> 
> could just use && token.length but OK for highlighting you have a number
> there.

Yeah, that's exactly what I was going for. I bit myself with this here at some point sometime.

Comment 5

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/0349be34cdc1

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/0349be34cdc1