The default bug view has changed. See this FAQ.

Don't change the selected script while filtering if the file part from the search expression hasn't changed

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Developer Tools: Debugger
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

12 Branch
Firefox 17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
If there are two very similarly named files, for example:

foo/bar/baz.js
baz.js

...then when trying a filter like baz.js#token, for each letter entered in the #token, the selected script switches to `foo/bar/todos.js` if the previously selected script was `todos.js`.

Thus, the script always switches to the first found mach. This annoyed me today.
(Assignee)

Comment 1

5 years ago
s/todos/baz :)
(Assignee)

Comment 2

5 years ago
Created attachment 650180 [details] [diff] [review]
v1
Attachment #650180 - Flags: review?(rcampbell)
(Assignee)

Updated

5 years ago
Blocks: 774788
Comment on attachment 650180 [details] [diff] [review]
v1

-    if (token.length) {
+    if (this._prevSearchedToken !== token && token.length > 0) {

could just use && token.length but OK for highlighting you have a number there.
Attachment #650180 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 4

5 years ago
(In reply to Rob Campbell [:rc] (:robcee) from comment #3)
> Comment on attachment 650180 [details] [diff] [review]
> v1
> 
> -    if (token.length) {
> +    if (this._prevSearchedToken !== token && token.length > 0) {
> 
> could just use && token.length but OK for highlighting you have a number
> there.

Yeah, that's exactly what I was going for. I bit myself with this here at some point sometime.
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/0349be34cdc1
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/0349be34cdc1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.