[shipping] create-milestones should only create milestones explicitly selected, inverse of now

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Pike, Assigned: peterbe)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Right now, create-milestones creates all milestones it could possibly ever want to, and then has crappy UI to get rid of those you don't want.

This lead to errors more than once.

Let's inverse this and only create those that we really want. By default, beta-only, not aurora-and-beta aside.

The reason this was is that I didn't want to find out how to get the suggested names and versions into the form, so I just filled the form completely, and then you can disable stuff.
(Reporter)

Updated

7 years ago
Priority: -- → P2
(Assignee)

Comment 1

7 years ago
Note-to-self: https://l10n.mozilla.org/shipping/release/select-milestones/

The New UI should make it explicit which ones to select; instead of a UI where you have remove (clicking the `x`) rows. 
E.g. unchecked checkboxes for the ones you want.
(Assignee)

Updated

7 years ago
Assignee: nobody → peterbe
(Assignee)

Comment 2

7 years ago
Here's what I've got so far.
http://cl.ly/J4OH

Just wanted to check that I've understood it correctly. 
When submitting this (see screenshot), it will now only create milestones for:

{u'fennec15': {'av': <AppVersion: Fennec 15>,
               'code': u'fennec15_beta_b1',
               'name': u'Beta Build 1'},
 u'fx15': {'av': <AppVersion: Firefox 15>,
           'code': u'fx15_beta_b1',
           'name': u'Beta Build 1'}}

I've got a few more things to tidy up but I just wanted to check that I'm on the right track.
(Reporter)

Comment 3

7 years ago
The concept works, I'd prefer to only see one of aurora or beta, with beta being visible. That way, we'd get good defaults.

Somewhat like

Beta - aurora
====
Firefox 15 Beta Build 1 fx15_beta_b1
Thunderbird...

vs

beta - Aurora 
       ======
Firefox 16 Beta Build 1 fx16_beta_b1
Thunderbird...

The Beta-Aurora is kinda like one of those mobile on/off sliders, or some radio control. By default, the Aurora variant of the UI would show only in one spot in the UI, so that it's discoverable if you know that you really need it. But it'd not be a real decision that releng folks would need to make.
(Assignee)

Comment 4

7 years ago
Notes-to-self:

* remove "Clear aurora" button

* replace it with a drop-down with options ("beta", "aurora")

* "beta" pre-selected in the drop-down

* changing from beta to aurora (or other way around) hides all beta and shows all aurora.

* Change submit button to "Create milestones".
(Assignee)

Comment 5

7 years ago
Once this lands on -dev, do a prod mysql dump to dev and invite RelEng to test shipping/release/select-milestones/ on -dev.
(Assignee)

Comment 6

7 years ago
Created attachment 656551 [details] [diff] [review]
As per our discussion

When you load it, it looks like this to boot:
http://cl.ly/J6Ym

The other important thing on the jQuery bit is that it unchecks anything that was previously checked but now hidden. 

jshint and check.py is happy.
Attachment #656551 - Flags: review?(l10n)
(Reporter)

Updated

7 years ago
Attachment #656551 - Flags: review?(l10n) → review+

Comment 7

7 years ago
Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/a3cbd700c9c4dab86c8aa7cc632a5cc454bad055
bug 780636 - ui improved for selecting appversions to build milestones on, r=Pike
(Assignee)

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 8

7 years ago
Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/009bfcefb5715f5ee69e08bcffd3562514962872
bug 780636, follow-up to change submit button label to Create Milestones
(Reporter)

Comment 9

7 years ago
(In reply to [github robot] from comment #8)
> Commit pushed to develop at https://github.com/mozilla/elmo
> 
> https://github.com/mozilla/elmo/commit/
> 009bfcefb5715f5ee69e08bcffd3562514962872
> bug 780636, follow-up to change submit button label to Create Milestones

We had talked about this change on the phone before, and both forgot about it when dealing with the actual patch, so I just slipped this in as a follow up.
You need to log in before you can comment on or make changes to this bug.