780638 - Rename getResponse to be more specific (getEventResponse)

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

getResponse is implemented by GeckoEventResponders. It would make sense if we had a lot of little classes that were just GeckoEventResponders, but the interface is usually implemented by much more complex classes, making the method name a bit too generic. We should name it something to help it make more sense.

mfinkle suggested getEventResponse in bug 769821.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Actually the better solution is to just make the handleMessage function return a String, which would be the event response. If we're refactoring all this code anyway that would be my preferred approach - the reason I didn't do that initially was just to minimize impact on existing code so we could get 14 out the door faster.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Also adding cpeterson since he's been refactoring the event code.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.