Closed Bug 780698 Opened 7 years ago Closed 7 years ago

Support more test suites in mozbuild

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: gps, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Bug 780329 added support for only a small subset of test suites in mozbuild. This bug tracks adding more, ideally all of them.
Assignee: nobody → Ms2ger
> 404 Not Found
>
> /tests/all was not found.

is not a useful response to ./mach mochitest-plain
Attachment #665579 - Flags: review?(gps)
Comment on attachment 665577 [details] [diff] [review]
Part a: Give _run_make append_env and explicit_env arguments

Review of attachment 665577 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #665577 - Flags: review?(gps) → review+
Comment on attachment 665579 [details] [diff] [review]
Part b: Fix mochitest runners

Review of attachment 665579 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM as long as you've tested that it works.
Attachment #665579 - Flags: review?(gps) → review+
Comment on attachment 665580 [details] [diff] [review]
Part c: Support mochitest-a11y, reftest, crashtest

Review of attachment 665580 [details] [diff] [review]:
-----------------------------------------------------------------

Aside from invalid comments and strings related to copying the mochitest's code, this looks good.

::: python/mozbuild/mozbuild/testing/reftest.py
@@ +43,5 @@
> +        top source directory, an absolute filename, or a directory containing
> +        test files.
> +
> +        suite is the type of mochitest to run. It can be one of ('plain',
> +        'chrome', 'browser').

Really?

@@ +47,5 @@
> +        'chrome', 'browser').
> +        """
> +
> +        if suite not in ('reftest', 'crashtest'):
> +            raise Exception('None or unrecognized mochitest suite type.')

mochitest?

::: python/mozbuild/mozbuild/testing/test.py
@@ +11,5 @@
> +
> +class TestRunner(MozbuildObject):
> +    """Base class to share code for parsing test paths."""
> +
> +    def _parse_test_path(self, test_path):

Thank you for consolidating this!
Attachment #665580 - Flags: review?(gps) → review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.